Merged
Conversation
Member
|
Wow. |
kou
reviewed
Jan 16, 2024
test/stringio/test_stringio.rb
Outdated
| s = StringIO.new('abcd') | ||
| s.seek(pos) | ||
| s.write("\xff\xff\xff") | ||
| refute(s.string.ascii_only?) |
Member
There was a problem hiding this comment.
Suggested change
| refute(s.string.ascii_only?) | |
| assert_operator(s.string, :ascii_only?) |
Member
Author
There was a problem hiding this comment.
changed to refute_predicate(s.string, :ascii_only?)
Member
There was a problem hiding this comment.
Oh, sorry.
Could you use assert_not_predicate instead? I don't want to use refute_* as much as possible because assert_not_ is straightforward for non-native English speaker.
tompng
force-pushed
the
write_ascii_fix
branch
from
ada1ece to
acaaa6e
Compare
Member
tompng
force-pushed
the
write_ascii_fix
branch
from
a051370 to
9faa0eb
Compare
tompng
changed the title
tompng
force-pushed
the
write_ascii_fix
branch
from
9faa0eb to
9b9dafa
Compare
tompng
changed the title
Member
Author
|
I add a test case s = StringIO.new("\u{3042}")
s.rewind
assert_not_predicate(s.string, :ascii_only?)
s.write('aaaa')
assert_predicate(s.string, :ascii_only?)that fails in master (after #79) Writing string in arbitary position(when Other variation: |
Member
|
Thanks! |
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jan 18, 2024
(ruby/stringio#77) Followup of #79 `rb_str_resize()` was changed by b0b9f72 . ```c rb_str_resize(string, shorter) // clear ENC_CODERANGE in some case rb_str_resize(string, longer) // does not clear ENC_CODERANGE anymore ``` ```c // rb_str_resize in string.c if (slen > len && ENC_CODERANGE(str) != ENC_CODERANGE_7BIT) { ENC_CODERANGE_CLEAR(str); } ``` I think this change is based on an assumption that appending null bytes will not change flag `ascii_only?`. `strio_extend()` will make the string longer if needed, and update the flags correctly for appending null bytes. Before `memmove()`, we need to `rb_str_modify()` because updated flags are not updated for `memmove()`. ruby/stringio@b31a538576
headius
added a commit
to headius/stringio
that referenced
this pull request
Feb 19, 2025
headius
added a commit
that referenced
this pull request
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.ruby-lang.org/issues/20185Followup of #79
Looks like rb_str_resize is changed in some ruby version
I think this change is based on an assumption that appending null bytes will not change flag
ascii_only?.strio_extendwill make the string longer if needed, and update the flags correctly for appending null bytes.Before memmove, we need to
rb_str_modifybecause updated flags are not updated for memmove.