Skip to content

Update for JRuby 9.2.17.0#165

Merged
eregon merged 3 commits intoruby:masterfrom
headius:jruby_9.2.17.0
Apr 2, 2021
Merged

Update for JRuby 9.2.17.0#165
eregon merged 3 commits intoruby:masterfrom
headius:jruby_9.2.17.0

Conversation

@headius
Copy link
Collaborator

@headius headius commented Mar 29, 2021

No description provided.

@headius
Copy link
Collaborator Author

headius commented Mar 29, 2021

What is the proper procedure for updating versions? I tried the pre-commit script but that seemed to break index.js. Editing index.js directly with my editor appears to replace all newlines with unix-style (are they windows style normally?)

@headius
Copy link
Collaborator Author

headius commented Mar 29, 2021

Redid the commit by editing files manually in vim, to avoid regenerating badly or replacing newlines.

@eregon
Copy link
Member

eregon commented Mar 30, 2021

The pre-commit should work. FWIW I have yarn v1.22.10 locally.
ncc is pinned to 0.23.0, so maybe you need yarn install before running the pre-commit hook.
I'll add yarn install to the hook.

We also need builds of the new release at https://github.com/ruby/ruby-builder, like ruby/ruby-builder@94ad658.
I did it in ruby/ruby-builder@1633b93
It would be nice to automate that so it'd be directly done as soon as a release is published on the jruby repo, but I didn't have time to look at that so far.

@eregon
Copy link
Member

eregon commented Mar 30, 2021

@headius JRuby 9.2.17 seems to have some issue on Windows, see
https://github.com/ruby/setup-ruby/pull/165/checks?check_run_id=2227889407

$ gem install sassc -N
Successfully installed ffi-1.15.0-java
Building native extensions. This could take a while...
ERROR:  Error installing sassc:
	ERROR: Failed to build gem native extension.

    current directory: D:/jruby-9.2.17.0/lib/ruby/gems/shared/gems/sassc-2.4.0/ext
D:/jruby-9.2.17.0/bin/jruby.exe -I D:/jruby-9.2.17.0/lib/ruby/stdlib -r ./siteconf20210330-2584-1pgoh9i.rb extconf.rb
extconf failedNo such file or directory - {"SOURCE_DATE_EPOCH"=>"1617110021"}

Gem files will remain installed in D:/jruby-9.2.17.0/lib/ruby/gems/shared/gems/sassc-2.4.0 for inspection.
Results logged to D:/jruby-9.2.17.0/lib/ruby/gems/shared/extensions/universal-java-1.8/2.5.0/sassc-2.4.0/gem_make.out

And it worked fine on 9.2.16 2 days ago in https://github.com/ruby/setup-ruby/runs/2212961109

@tedt10e
Copy link

tedt10e commented Apr 2, 2021

Hi @headius @eregon

Would this version be released soon?

Thanks 🙏

@eregon
Copy link
Member

eregon commented Apr 2, 2021

I filed a JRuby issue about this failure: jruby/jruby#6648
Given that installing sassc on JRuby on Windows is probably something most users won't do, and they can pin to 9.2.16.0 if needed, I'll merge this.
I'll need to exclude that test on JRuby to keep the CI green then.

@eregon eregon merged commit ad65390 into ruby:master Apr 2, 2021
@eregon
Copy link
Member

eregon commented Apr 2, 2021

@tedhexaflow released now.

@tedt10e
Copy link

tedt10e commented Apr 2, 2021

Thank you so much 🙏🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants