Dir.each_child: also yield the child type #15667
Draft
+92
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are numerous ruby tools that need to recursively scan the project directory, such as Zeitwerk, rubocop, etc.
All of them end up listing childs of a directory then for each child emit a
statcall to check if it's a directory or not.This is common enough for a pattern that on most operating systems,
struct direntinclude adtypemember that allows to check the file type without issuing a any extra system calls.By yielding that type, we can make these routines twice as fast.