[4.1] Use atomic for temporarily waiting SNTs #15597
Draft
+37
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobu
reviewed
Dec 17, 2025
Comment on lines
+714
to
+715
| unsigned int snt_cnt; // count of shared NTs (including waiting) | ||
| rb_atomic_t waiting_snt_cnt; // count of shared NTs in blocking calls |
jhawthorn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use
ractor_sched_lockto serialize changes to a Ractor's state when we go to/from waiting for the GVL. This changes that operation to use an atomic for the case that we expect to return as an SNT later.