Make Monitor a core class #15538
Open
Make Monitor a core class #15538
+330
−480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
byroot
force-pushed
the
core-monitor
branch
6 times, most recently
from
f5013f6 to
634545f
Compare
Member
|
You might want to move |
Member
Author
|
@nobu I did, no? |
Member
|
|
Member
Author
|
Oh woops. |
byroot
force-pushed
the
core-monitor
branch
4 times, most recently
from
ad78b6e to
32815a1
Compare
[Feature #21788] It allows monitor to access internal routines and remove some overhead. Before: ``` ruby 4.0.0dev (2025-12-13T04:52:13Z master 71dd272) +YJIT +PRISM [arm64-darwin25] Warming up -------------------------------------- Mutex 2.111M i/100ms Monitor 1.736M i/100ms Calculating ------------------------------------- Mutex 25.050M (± 0.4%) i/s (39.92 ns/i) - 126.631M in 5.055208s Monitor 19.809M (± 0.1%) i/s (50.48 ns/i) - 100.672M in 5.082015s ``` After: ``` ruby 4.0.0dev (2025-12-13T06:49:18Z core-monitor 6fabf38) +YJIT +PRISM [arm64-darwin25] Warming up -------------------------------------- Mutex 2.144M i/100ms Monitor 1.859M i/100ms Calculating ------------------------------------- Mutex 24.771M (± 0.4%) i/s (40.37 ns/i) - 124.342M in 5.019716s Monitor 23.722M (± 0.4%) i/s (42.15 ns/i) - 118.998M in 5.016361s ``` Bench: ```ruby require 'bundler/inline' gemfile do gem "benchmark-ips" end mutex = Mutex.new require "monitor" monitor = Monitor.new Benchmark.ips do |x| x.report("Mutex") { mutex.synchronize { } } x.report("Monitor") { monitor.synchronize { } } end ```
eregon
reviewed
Dec 17, 2025
|
|
||
| # Ignore CRuby internals | ||
| features -= %w[encdb transdb windows_1252 windows_31j] | ||
| features -= %w[encdb transdb windows_1252 windows_31 monitor] |
Member
There was a problem hiding this comment.
monitor is not CRuby internal (it's a long-time stdlib/well known feature name), so let's add it under a ruby_version_is "4.1" do guard like pathname below
Member
There was a problem hiding this comment.
i.e. the point is that other Ruby implementations should also to rb_provide() or equivalent so require "monitor" keeps working.
eregon
reviewed
Dec 17, 2025
| # | ||
| # Copyright (C) 2001 Shugo Maeda <shugo@ruby-lang.org> | ||
| # | ||
| # This library is distributed under the terms of the Ruby license. |
Member
There was a problem hiding this comment.
Why not move this whole file in thread_sync.rb or /monitor.rb?
eregon
reviewed
Dec 17, 2025
| # # exclusive access | ||
| # end | ||
| # | ||
| class Monitor |
Member
There was a problem hiding this comment.
I don't think this file should define any method on Monitor if Monitor is core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Feature #21788]
It allows monitor to access internal routines and remove some overhead.
Before:
After:
Bench: