Skip to content

ZJIT: Track guard shape exit ratio #15052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2025
Merged

ZJIT: Track guard shape exit ratio #15052

merged 1 commit into from
Nov 5, 2025
+6 −1

Conversation

@rwstauner
Copy link
Contributor

@rwstauner rwstauner commented Nov 4, 2025 •
edited
Loading

new ZJIT stats excerpt from liquid-runtime:

    vm_read_from_parent_iseq_local_count:        10,909,753
    guard_type_count:                            45,109,441
    guard_type_exit_ratio:                             4.3%
    guard_shape_count:                           15,272,133
    guard_shape_exit_ratio:                           20.1%
    code_region_bytes:                            3,899,392

lobsters

guard_type_count:                            71,765,580
guard_type_exit_ratio:                             4.3%
guard_shape_count:                           21,872,560
guard_shape_exit_ratio:                            8.0%

railsbench

guard_type_count:                            117,661,124
guard_type_exit_ratio:                              0.7%
guard_shape_count:                            28,032,665
guard_shape_exit_ratio:                             5.1%

shipit

guard_type_count:                            106,195,615
guard_type_exit_ratio:                              3.5%
guard_shape_count:                            33,672,673
guard_shape_exit_ratio:                            10.1%

@matzbot matzbot requested a review from a team November 4, 2025 19:41
@tekknolagi
Copy link
Contributor

tekknolagi commented Nov 4, 2025

Implementation looks good to me -- can we please get some numbers for lobsters/railsbench/shipit?

@tekknolagi tekknolagi enabled auto-merge (squash) November 4, 2025 19:59
@launchable-app

This comment has been minimized.

Sign in to view
k0kubun
k0kubun reviewed Nov 4, 2025
View reviewed changes
zjit.rb
when :ratio_in_zjit
value = '%0.1f%%' % value
when :guard_type_exit_ratio
when :guard_type_exit_ratio, :guard_shape_exit_ratio
Copy link
Member

@k0kubun k0kubun Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge this when with the above when :ratio_in_zjit? I couldn't figure out why they're separate.

auto-merge was automatically disabled November 5, 2025 03:15

Head branch was pushed to by a user without write access

@rwstauner rwstauner force-pushed the rwstauner/zjit-guard-shape-ratio branch from 09efe42 to 435d571 Compare November 5, 2025 03:15
@tekknolagi tekknolagi merged commit d327eb6 into ruby:master Nov 5, 2025
99 of 101 checks passed
@tekknolagi tekknolagi deleted the rwstauner/zjit-guard-shape-ratio branch November 5, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@k0kubun k0kubun k0kubun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rwstauner @tekknolagi @k0kubun