-
Notifications
You must be signed in to change notification settings - Fork 5.5k
ZJIT: Run ruby-bench CI for macOS arm64 as well #15040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
5507e75 to
15d0b6e
Compare
15d0b6e to
49d1c64
Compare
|
idea lgtm but no familiarity with the yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
Thanks for your reviews! Looking at the list of jobs again, I rethought that it's nice to have a view that has every job for each architecture so that you can monitor the test progress of a particular architecture by just opening one page. So I changed the way it's implemented, and it now lives under |
|
oh no :( |
|
Heh, good thing I updated it again before landing it. |
|
Filed #15057. I confirmed that it fixes crashes using the same setup as this PR. As of filing #14936, they weren't reproducible. While I was waiting for reviews on it, #15033 was merged, and then I merged mine. So that seems to have triggered the They can be prevented once we merge this PR. But we need to land #15057 first. |
This extends #15003 to run ruby-bench for arm64 as well.
It's been fairly stable so far, and we should use it for catching arm64-specific bugs too. Due to the nature that it depends on so many third-party gems, I'm still not making it a required status check though.