Extract keyword arg constant for JITs #15039
Open
+26
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
XrXr
reviewed
Nov 3, 2025
|
I suggested new header because vm_args otherwise doesn't include anything. If that's ok, we can move to core |
|
vm_args.c is included into vm.c to make vm.o, so it itself is kinda sorta a header or fragment of a translation unit, that's why it didn't have a header. It's more natural for stuff related to it to be in headers for the VM translation unit because of that topology, I think. |
|
Thanks for the info! Sounds great (and easier) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZJIT and YJIT often require the use of magic numbers that correspond to C macro definitions. This PR adds
internal/args.hto enforce a single source of truth.Additionally, extract
KW_SPECIFIED_BITS_MAXtointernal/args.h.