Don't call size on the input to Set.new
#14990
Open
+19
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyevans
approved these changes
Oct 29, 2025
tekknolagi
reviewed
Oct 29, 2025
Calling `size` can cause side effects that we previously didn't have. In this patch, we test `end` on Ranges to see if they are infinite, but we simply iterate over other inputs. ref: https://bugs.ruby-lang.org/issues/21654 [Bug #21654]
tenderlove
force-pushed
the
no-size-call
branch
from
d4c7f66 to
70883db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
sizecan cause side effects that we previously didn't have. In this patch, we testendon Ranges to see if they are infinite, but we simply iterate over other inputs.ref: https://bugs.ruby-lang.org/issues/21654
[Bug #21654]