Skip to content

Fix performance issue caused by using repeated > characters inside <xml><!-- --></xml> #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 2 commits into from
Jul 16, 2024
Merged

Fix performance issue caused by using repeated > characters inside <xml><!-- --></xml> #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce3ba6a
Fix performance issue caused by using repeated `>` characters inside …
Watson1978 Jul 11, 2024
17fd8e8
Remove redundant "comment"
kou Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rexml/parsers/baseparser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ def pull_event
#STDERR.puts "SOURCE BUFFER = #{source.buffer}, #{source.buffer.size}"
raise REXML::ParseException.new("Malformed node", @source) unless md
if md[0][0] == ?-
md = @source.match(/--(.*?)-->/um, true)
md = @source.match(/--(.*?)-->/um, true, term: Private::COMMENT_TERM)

if md.nil? || /--|-\z/.match?(md[1])
raise REXML::ParseException.new("Malformed comment", @source)
Expand Down
7 changes: 7 additions & 0 deletions test/parse/test_comment.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,5 +128,12 @@ def test_gt_linear_performance
REXML::Document.new('<!-- ' + ">" * n + ' -->')
end
end

def test_gt_linear_performance_in_element
seq = [10000, 50000, 100000, 150000, 200000]
assert_linear_performance(seq, rehearsal: 10) do |n|
REXML::Document.new('<xml><!-- ' + '>' * n + ' --></xml>')
end
end
end
end