Fix a false positive for Rails/UniqBeforePluck when using a numblock with uniq

Earlopain · Earlopain · commit 78988e779796 · 2025-02-28T15:11:54.000+01:00
diff --git a/changelog/fix_false_positive_uniq_before_pluck_numblock.md b/changelog/fix_false_positive_uniq_before_pluck_numblock.md
@@ -0,0 +1 @@
+* [#1459](https://github.com/rubocop/rubocop-rails/pull/1459): Fix a false positive for `Rails/UniqBeforePluck` when using a numblock with `uniq`. ([@earlopain][])
diff --git a/lib/rubocop/cop/rails/uniq_before_pluck.rb b/lib/rubocop/cop/rails/uniq_before_pluck.rb
@@ -52,7 +52,7 @@ class UniqBeforePluck < Base
         MSG = 'Use `distinct` before `pluck`.'
         RESTRICT_ON_SEND = %i[uniq].freeze
 
-        def_node_matcher :uniq_before_pluck, '[!^block $(send $(send _ :pluck ...) :uniq ...)]'
+        def_node_matcher :uniq_before_pluck, '[!^any_block $(send $(send _ :pluck ...) :uniq ...)]'
 
         def on_send(node)
           uniq_before_pluck(node) do |uniq_node, pluck_node|
diff --git a/spec/rubocop/cop/rails/uniq_before_pluck_spec.rb b/spec/rubocop/cop/rails/uniq_before_pluck_spec.rb
@@ -74,6 +74,12 @@
         Model.where(foo: 1).pluck(:name).uniq { |k| k[0] }
       RUBY
     end
+
+    it 'ignores uniq with a numblock' do
+      expect_no_offenses(<<~RUBY)
+        Model.where(foo: 1).pluck(:name).uniq { _1[0] }
+      RUBY
+    end
   end
 
   it 'registers an offense' do

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+* [#1459](https://github.com/rubocop/rubocop-rails/pull/1459): Fix a false positive for `Rails/UniqBeforePluck` when using a numblock with `uniq`. ([@earlopain][])