aspa: Fix ASPA validation for AS paths with AS path prepending#320
Open
aspa: Fix ASPA validation for AS paths with AS path prepending#320
Conversation
Previously, the ASPA validation was not performed on the compressed AS path which yielded incorrect results for AS paths where at least one AS number appeared multiple times in a row and that AS did not add itself as a provider in its ASPA record. This was against the ASPA RFC, which mandates validation on the compressed AS path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Previously, the ASPA validation was not performed on the compressed AS path which yielded incorrect results for AS paths where at least one AS number appeared multiple times in a row and that AS did not add itself as a provider in its ASPA record. This was against the ASPA RFC, which mandates validation on the compressed AS path.
Testing procedure
The existing ASPA test have been fixed and extended so that the ASPA validation of AS paths with AS path prepending is tested for the upstream and downstream direction.
Issues/PRs references
n/a