Skip to content

rtr: fix race condition on rtr_start/rtr_close#273

Open
mroethke wants to merge 1 commit intortrlib:masterfrom
mroethke:fix_271
Open

rtr: fix race condition on rtr_start/rtr_close#273
mroethke wants to merge 1 commit intortrlib:masterfrom
mroethke:fix_271

Conversation

@mroethke
Copy link
Member

@mroethke mroethke commented Jan 21, 2022

It was possible for two threads to be started for the same socket
because the check supposed to prevent this used an unsynchronized
variable.

Fix #271

@mroethke
rtr: fix race condition on rtr_start/rtr_close
2d0890f 
It was possible for two threads to be started for the same socket
because the check supposed to prevent this used an unsynchronized
variable.
@mroethke
Copy link
Member Author

mroethke commented Jan 21, 2022

@Jaykov-s please confirm that this fixes the problem

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jan 21, 2022

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/RPKI-RTRLIBPR-391/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 11 amd64: Failed (click for details) Debian 11 amd64: No useful log found
Successful on other platforms/tests
  • NetBSD 9 amd64
  • Fedora 29 amd64
  • Ubuntu 18.04 i386
  • OpenBSD 7 amd64
  • Ubuntu 18.04 amd64
  • Debian 9 arm7
  • Ubuntu 16.04 arm8
  • CentOS 7 amd64
  • Debian 9 arm8
  • Fedora 31 amd64
  • CentOS 6 amd64
  • Alpine amd64
  • FreeBSD 12 amd64
  • Debian 10 amd64
  • FreeBSD 11 amd64
  • Ubuntu 18.04 ppc64le
  • Redhat 8 amd64
  • Ubuntu 18.04 arm8
  • Ubuntu 16.04 amd64
  • Ubuntu 16.04 arm7
  • Ubuntu 16.04 i386
  • Ubuntu 18.04 arm7
  • Ubuntu 14.04 amd64
  • Ubuntu 20.04 arm8
  • Debian 9 amd64
  • Debian 8 amd64

Warnings Generated during build:

Ubuntu 18.04 i386: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 i386:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-391/artifact/U18I386/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: priority-extra-is-replaced-by-priority-optional
W: librtr0: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: priority-extra-is-replaced-by-priority-optional
Ubuntu 18.04 amd64: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 amd64:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-391/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: priority-extra-is-replaced-by-priority-optional
W: librtr-doc: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: priority-extra-is-replaced-by-priority-optional
W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
Debian 9 arm7: Successful with additional warnings

Debian Package lintian failed for Debian 9 arm7:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-391/artifact/D9BUILDARM7/ErrorLog/log_lintian.txt)

W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
Ubuntu 16.04 arm8: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 arm8:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-391/artifact/UBUNTU1604ARM8/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
Debian 9 arm8: Successful with additional warnings

Debian Package lintian failed for Debian 9 arm8:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-391/artifact/D9BUILDARM8/ErrorLog/log_lintian.txt)

W: librtr-doc: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
Debian 10 amd64: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-391/artifact/DEB10AMD64/ErrorLog/log_lintian.txt)

W: librtr0: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: priority-extra-is-replaced-by-priority-optional
W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: priority-extra-is-replaced-by-priority-optional
W: rtr-tools: debian-changelog-line-too-long line 13
N: 0 tags overridden; 6 unused overrides
Ubuntu 18.04 ppc64le: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 ppc64le:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-391/artifact/U1804PPC64LE/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: librtr0: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: priority-extra-is-replaced-by-priority-optional
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: priority-extra-is-replaced-by-priority-optional
W: librtr-doc: debian-changelog-line-too-long line 13
Ubuntu 18.04 arm8: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 arm8:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-391/artifact/U1804ARM8/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: priority-extra-is-replaced-by-priority-optional
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: priority-extra-is-replaced-by-priority-optional
W: librtr0: debian-changelog-line-too-long line 13
Ubuntu 16.04 amd64: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 amd64:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-391/artifact/UBUNTU1604AMD64/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: librtr0: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
Ubuntu 16.04 arm7: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 arm7:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-391/artifact/UBUNTU1604ARM7/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: librtr0: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
Ubuntu 16.04 i386: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 i386:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-391/artifact/UBUNTU1604I386/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
Ubuntu 18.04 arm7: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 arm7:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-391/artifact/U1804ARM7/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: priority-extra-is-replaced-by-priority-optional
W: librtr-doc: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: priority-extra-is-replaced-by-priority-optional
W: librtr-dev: debian-changelog-line-too-long line 13
Ubuntu 14.04 amd64: Successful with additional warnings

Debian Package lintian failed for Ubuntu 14.04 amd64:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-391/artifact/UBUNTU1404AMD64/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
Ubuntu 20.04 arm8: Successful with additional warnings

Debian Package lintian failed for Ubuntu 20.04 arm8:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-391/artifact/U2004ARM8/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: priority-extra-is-replaced-by-priority-optional
W: rtr-tools-dbg: priority-extra-is-replaced-by-priority-optional
Debian 9 amd64: Successful with additional warnings

Debian Package lintian failed for Debian 9 amd64:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-391/artifact/DEBIAN9AMD64/ErrorLog/log_lintian.txt)

W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
Debian 8 amd64: Successful with additional warnings

Debian Package lintian failed for Debian 8 amd64:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-391/artifact/DEBIAN8AMD64/ErrorLog/log_lintian.txt)

W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13

@waehlisch
Copy link
Member

waehlisch commented Jan 23, 2022

CI:rerun

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jan 23, 2022

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/RPKI-RTRLIBPR-395/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Ubuntu 18.04 amd64: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 amd64:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-395/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: priority-extra-is-replaced-by-priority-optional
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: priority-extra-is-replaced-by-priority-optional
Ubuntu 18.04 i386: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 i386:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-395/artifact/U18I386/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: priority-extra-is-replaced-by-priority-optional
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: priority-extra-is-replaced-by-priority-optional
W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
Ubuntu 18.04 ppc64le: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 ppc64le:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-395/artifact/U1804PPC64LE/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: priority-extra-is-replaced-by-priority-optional
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: priority-extra-is-replaced-by-priority-optional
Debian 11 amd64: Successful with additional warnings

Debian Package lintian failed for Debian 11 amd64:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-395/artifact/DEB11AMD64/ErrorLog/log_lintian.txt)

E: librtr-dbg: malformed-override Unknown tag latest-debian-changelog-entry-changed-to-native in line 1
E: librtr-dev: malformed-override Unknown tag latest-debian-changelog-entry-changed-to-native in line 1
E: librtr-doc: malformed-override Unknown tag latest-debian-changelog-entry-changed-to-native in line 1
E: librtr0: malformed-override Unknown tag latest-debian-changelog-entry-changed-to-native in line 1
E: rtr-tools: malformed-override Unknown tag latest-debian-changelog-entry-changed-to-native in line 1
E: rtr-tools-dbg: malformed-override Unknown tag latest-debian-changelog-entry-changed-to-native in line 1
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: priority-extra-is-replaced-by-priority-optional
W: rtr-tools-dbg: priority-extra-is-replaced-by-priority-optional
Ubuntu 16.04 arm7: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 arm7:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-395/artifact/UBUNTU1604ARM7/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: librtr0: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
Debian 10 amd64: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-395/artifact/DEB10AMD64/ErrorLog/log_lintian.txt)

W: librtr0: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: priority-extra-is-replaced-by-priority-optional
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: priority-extra-is-replaced-by-priority-optional
N: 0 tags overridden; 6 unused overrides
Debian 9 arm7: Successful with additional warnings

Debian Package lintian failed for Debian 9 arm7:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-395/artifact/D9BUILDARM7/ErrorLog/log_lintian.txt)

W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
Ubuntu 16.04 arm8: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 arm8:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-395/artifact/UBUNTU1604ARM8/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
Debian 9 arm8: Successful with additional warnings

Debian Package lintian failed for Debian 9 arm8:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-395/artifact/D9BUILDARM8/ErrorLog/log_lintian.txt)

W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
Ubuntu 16.04 amd64: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 amd64:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-395/artifact/UBUNTU1604AMD64/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: librtr0: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
Debian 9 amd64: Successful with additional warnings

Debian Package lintian failed for Debian 9 amd64:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-395/artifact/DEBIAN9AMD64/ErrorLog/log_lintian.txt)

W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
Ubuntu 16.04 i386: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 i386:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-395/artifact/UBUNTU1604I386/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
Ubuntu 18.04 arm7: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 arm7:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-395/artifact/U1804ARM7/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: librtr-dev: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: priority-extra-is-replaced-by-priority-optional
W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: priority-extra-is-replaced-by-priority-optional
Ubuntu 14.04 amd64: Successful with additional warnings

Debian Package lintian failed for Ubuntu 14.04 amd64:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-395/artifact/UBUNTU1404AMD64/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
Ubuntu 20.04 arm8: Successful with additional warnings

Debian Package lintian failed for Ubuntu 20.04 arm8:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-395/artifact/U2004ARM8/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: priority-extra-is-replaced-by-priority-optional
W: rtr-tools-dbg: priority-extra-is-replaced-by-priority-optional
Ubuntu 18.04 arm8: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 arm8:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-395/artifact/U1804ARM8/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: priority-extra-is-replaced-by-priority-optional
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: priority-extra-is-replaced-by-priority-optional
Debian 8 amd64: Successful with additional warnings

Debian Package lintian failed for Debian 8 amd64:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-395/artifact/DEBIAN8AMD64/ErrorLog/log_lintian.txt)

W: librtr-doc: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13

@Jaykov-s
Copy link

Jaykov-s commented Jan 23, 2022

@mroethke Hi, it's seem that it solve the issue. Thanks.
Jaykovs

@fho fho self-requested a review April 1, 2024 08:44
@fho fho requested review from Nimuedaertya and tanneberger June 11, 2024 07:36
Nimuedaertya
Nimuedaertya approved these changes Jun 11, 2024
View reviewed changes
Copy link

@Nimuedaertya Nimuedaertya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looked at the code. Seems good.

@waehlisch
Copy link
Member

waehlisch commented Aug 12, 2024

CI:rerun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nimuedaertya Nimuedaertya Nimuedaertya approved these changes

@fho fho Awaiting requested review from fho

@tanneberger tanneberger Awaiting requested review from tanneberger

Assignees

@waehlisch waehlisch

Labels

type:bug type:enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crash

5 participants

@mroethke @NetDEF-CI @waehlisch @Jaykov-s @Nimuedaertya