Skip to content

check-exports.sh: add more functions to ignorelist#264

Closed
colinbs wants to merge 1 commit intortrlib:masterfrom
colinbs:fix_check-exports_failures
Closed

check-exports.sh: add more functions to ignorelist#264
colinbs wants to merge 1 commit intortrlib:masterfrom
colinbs:fix_check-exports_failures

Conversation

@colinbs
Copy link
Member

@colinbs colinbs commented Oct 16, 2021

Contribution description

travis.sh fails locally after executing check-exports.sh with the make gcov setup. Not sure if this is even a problem.
Adding the following functions to the ignorelist in check-exports.sh fixes the problem:

  • __gcov_error_file
  • __gcov_kvp_dynamic_pool
  • __gcov_kvp_dynamic_pool_index
  • __gcov_kvp_dynamic_pool_size
  • mangle_path

Issues/PRs references

Fixes #263

@colinbs
check-exports.sh: add more functions to ignorelist
d00cf6d 
Add the following functions to the ignorelist in check-exports.sh:
- __gcov_error_file
- __gcov_kvp_dynamic_pool
- __gcov_kvp_dynamic_pool_index
- __gcov_kvp_dynamic_pool_size
- mangle_path
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Oct 16, 2021

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/RPKI-RTRLIBPR-348/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Ubuntu 20.04 arm8: Successful with additional warnings

Debian Package lintian failed for Ubuntu 20.04 arm8:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-348/artifact/U2004ARM8/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: priority-extra-is-replaced-by-priority-optional
W: rtr-tools-dbg: priority-extra-is-replaced-by-priority-optional
Ubuntu 18.04 arm8: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 arm8:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-348/artifact/U1804ARM8/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: priority-extra-is-replaced-by-priority-optional
W: librtr0: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: priority-extra-is-replaced-by-priority-optional
W: librtr-dev: debian-changelog-line-too-long line 13
Ubuntu 18.04 ppc64le: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 ppc64le:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-348/artifact/U1804PPC64LE/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: priority-extra-is-replaced-by-priority-optional
W: librtr0: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: priority-extra-is-replaced-by-priority-optional
W: rtr-tools: debian-changelog-line-too-long line 13
Debian 8 amd64: Successful with additional warnings

Debian Package lintian failed for Debian 8 amd64:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-348/artifact/DEBIAN8AMD64/ErrorLog/log_lintian.txt)

W: rtr-tools: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
Ubuntu 16.04 arm7: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 arm7:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-348/artifact/UBUNTU1604ARM7/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
Debian 11 amd64: Successful with additional warnings

Debian Package lintian failed for Debian 11 amd64:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-348/artifact/DEB11AMD64/ErrorLog/log_lintian.txt)

E: librtr-dbg: malformed-override Unknown tag latest-debian-changelog-entry-changed-to-native in line 1
E: librtr-dev: malformed-override Unknown tag latest-debian-changelog-entry-changed-to-native in line 1
E: librtr-doc: malformed-override Unknown tag latest-debian-changelog-entry-changed-to-native in line 1
E: librtr0: malformed-override Unknown tag latest-debian-changelog-entry-changed-to-native in line 1
E: rtr-tools: malformed-override Unknown tag latest-debian-changelog-entry-changed-to-native in line 1
E: rtr-tools-dbg: malformed-override Unknown tag latest-debian-changelog-entry-changed-to-native in line 1
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: priority-extra-is-replaced-by-priority-optional
W: rtr-tools-dbg: priority-extra-is-replaced-by-priority-optional
Ubuntu 16.04 arm8: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 arm8:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-348/artifact/UBUNTU1604ARM8/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
Debian 9 amd64: Successful with additional warnings

Debian Package lintian failed for Debian 9 amd64:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-348/artifact/DEBIAN9AMD64/ErrorLog/log_lintian.txt)

W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
Ubuntu 16.04 amd64: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 amd64:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-348/artifact/UBUNTU1604AMD64/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
Ubuntu 16.04 i386: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 i386:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-348/artifact/UBUNTU1604I386/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: librtr-dbg: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
Ubuntu 18.04 i386: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 i386:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-348/artifact/U18I386/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: priority-extra-is-replaced-by-priority-optional
W: librtr-doc: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: priority-extra-is-replaced-by-priority-optional
W: rtr-tools: debian-changelog-line-too-long line 13
Ubuntu 18.04 amd64: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 amd64:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-348/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: priority-extra-is-replaced-by-priority-optional
W: librtr0: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: priority-extra-is-replaced-by-priority-optional
Debian 9 arm7: Successful with additional warnings

Debian Package lintian failed for Debian 9 arm7:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-348/artifact/D9BUILDARM7/ErrorLog/log_lintian.txt)

W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
Ubuntu 14.04 amd64: Successful with additional warnings

Debian Package lintian failed for Ubuntu 14.04 amd64:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-348/artifact/UBUNTU1404AMD64/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
Debian 9 arm8: Successful with additional warnings

Debian Package lintian failed for Debian 9 arm8:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-348/artifact/D9BUILDARM8/ErrorLog/log_lintian.txt)

W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
Debian 10 amd64: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-348/artifact/DEB10AMD64/ErrorLog/log_lintian.txt)

W: rtr-tools: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: priority-extra-is-replaced-by-priority-optional
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: priority-extra-is-replaced-by-priority-optional
W: librtr-doc: debian-changelog-line-too-long line 13
N: 0 tags overridden; 6 unused overrides
Ubuntu 18.04 arm7: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 arm7:
(see full package build log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-348/artifact/U1804ARM7/ErrorLog/log_lintian.txt)

E: librtr0 changes: bad-distribution-in-changes-file stable
W: rtr-tools-dbg: debian-changelog-line-too-long line 13
W: rtr-tools-dbg: priority-extra-is-replaced-by-priority-optional
W: librtr-dbg: debian-changelog-line-too-long line 13
W: librtr-dbg: priority-extra-is-replaced-by-priority-optional
W: librtr-dev: debian-changelog-line-too-long line 13
W: librtr0: debian-changelog-line-too-long line 13
W: librtr-doc: debian-changelog-line-too-long line 13
W: rtr-tools: debian-changelog-line-too-long line 13

@mroethke
Copy link
Member

mroethke commented Oct 26, 2021

I think a better solution would be to not do the exports check on a gcov enabled binary.
I will include that change in #265

@mroethke mroethke closed this Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

travis.sh fails on check-exports.sh

3 participants

@colinbs @NetDEF-CI @mroethke