Skip to content

refactor(client): use named imports for hot emitter and log#73

Draft
Timeless0911 wants to merge 1 commit intomainfrom
use-named-import
Draft

refactor(client): use named imports for hot emitter and log#73
Timeless0911 wants to merge 1 commit intomainfrom
use-named-import

Conversation

@Timeless0911
Copy link
Member

@Timeless0911 Timeless0911 commented Feb 4, 2026 •
edited
Loading

NOTICE: MERGE IT AFTER BUMPING RSPACK V2

Description

This PR refactors the client code to use named imports for @rspack/core/hot/emitter.js and @rspack/core/hot/log.js instead of default imports.

Related Issue

N/A

Checklist

  • Refactored client imports

Copilot AI review requested due to automatic review settings February 4, 2026 05:30
@gemini-code-assist
Copy link

gemini-code-assist bot commented Feb 4, 2026

Summary of Changes

Hello @Timeless0911, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing code consistency and maintainability within the client-side codebase. It achieves this by standardizing the import mechanisms for specific modules, transitioning from default imports to named imports. This change aligns with modern JavaScript module practices, improving clarity and potentially aiding static analysis.

Highlights

  • Import Refactoring: The client-side code has been refactored to use named imports for the hotEmitter module from @rspack/core/hot/emitter.js.
  • Import Refactoring: The client-side code now uses named imports for the webpackHotLog module from @rspack/core/hot/log.js.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • client-src/index.ts
    • Changed the import statement for hotEmitter from a default import to a named import ({ emitter as hotEmitter }).
    • Changed the import statement for webpackHotLog from a default import to a named import ({ log as webpackHotLog }).
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 4, 2026
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the client code to use named imports for @rspack/core/hot/emitter.js and @rspack/core/hot/log.js. This is a good change that improves the explicitness of the imports. The implementation is correct and I have no further comments.

@Timeless0911 Timeless0911 marked this pull request as draft February 4, 2026 05:31
Copilot AI reviewed Feb 4, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the dev-server runtime client to import the Rspack HMR emitter and logger via named exports instead of default exports.

Changes:

  • Switched @rspack/core/hot/emitter.js import to a named import (emitter aliased to hotEmitter).
  • Switched @rspack/core/hot/log.js import to a named import (log aliased to webpackHotLog).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Timeless0911