Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR ports the core functionality from webpack-dev-server@5 to @rspack/dev-server to provide feature parity for Rspack users. The implementation includes:
Changes:
- Removed dependency on webpack-dev-server and implemented core server functionality directly
- Added comprehensive server implementations (WebSocket, SockJS) with base abstractions
- Ported client-side modules for HMR, overlay, progress indicators, and WebSocket communication
- Added build infrastructure for client modules bundling
- Updated configuration schema and type definitions
Reviewed changes
Copilot reviewed 41 out of 45 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/server.ts | Complete rewrite implementing dev server from scratch |
| src/servers/*.ts | New WebSocket server implementations (BaseServer, WebsocketServer, SockJSServer) |
| src/getPort.ts | New port allocation utility |
| src/patch.ts | Removed (no longer needed with native implementation) |
| src/index.ts | Updated to export new Server class |
| src/options.json | New comprehensive dev server options schema |
| client-src/*.ts | New client-side modules for HMR and dev server communication |
| scripts/build-client-modules.cjs | New build script for client module bundling |
| tsconfig*.json | Updated TypeScript configurations |
| package.json | Updated dependencies and exports |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chenjiahan
reviewed
Jan 13, 2026
Member
chenjiahan
left a comment
chenjiahan
left a comment
There was a problem hiding this comment.
Could we update the credits to clarify that this project is forked from webpack-dev-server?
https://github.com/rstackjs/rspack-dev-server?tab=readme-ov-file#credits
Contributor
Author
Done |
chenjiahan
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR ports the core functionality from
webpack-dev-server@5to@rspack/dev-serverto provide a comprehensive development server experience for Rspack users. The porting effort includes:This change enables
@rspack/dev-serverto offer feature parity withwebpack-dev-server, allowing developers to seamlessly migrate from webpack to Rspack while maintaining the same development experience. The implementation follows the same architecture and patterns as webpack-dev-server, ensuring compatibility and familiarity for existing users.Checklist