Skip to content

fix broadcasting hack #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rsokl merged 2 commits into from
Dec 4, 2021
Merged

fix broadcasting hack #391

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caaf356
fix broadcasting hack
Dec 4, 2021
0440e7d
change fix to avoid weird py39 segfaults
Dec 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions tests/math/binary/test_binary_funcs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import hypothesis.strategies as st
import numpy as np
import pytest
from hypothesis import given
from hypothesis import given, assume
from numpy.testing import assert_allclose

from tests.custom_strategies import tensors
Expand All @@ -20,17 +20,17 @@ def inplace_op(inplace_target, other, constant=False, *, op_name: str):

op_name = "__" + op_name + "__"

# hack to make broadcastable shapes work for inplace op:
# 1. Ensure that inplace op has at least as many items as `other`.
# 2. `other` can't have excess leading dims
inplace_target, other = (
(inplace_target, other)
if inplace_target.size >= other.size
else (other, inplace_target)
)
if other.ndim > inplace_target.ndim:
other = other[(0,) * (other.ndim - inplace_target.ndim)]

# hack to make broadcastable shapes work for inplace op:
x = inplace_target.copy()
check = False

if np.broadcast(inplace_target, other).shape != inplace_target.shape:
inplace_target, other = other, inplace_target
check = True

if check and np.broadcast(inplace_target, other).shape != inplace_target.shape:
assume(False)
# touch so that it doesn't look like the input
# was mutated
inplace_target = +inplace_target
Expand Down