Feature/google java format 1.4#403
Closed
qweek wants to merge 4 commits into
Closed
Conversation
configuration: explicitly set gradle version and distribution type (upgrade later) versions: move dependency versions to separate file java: set encoding to UTF-8 disable specific compiler warnings (fix later) codestyle: set google java format version for plugin (upgrade later) run formatting before compilation benchmark: exclude test dependencies from jmh jar fix duplicate jmh generated classes (jmh-generated-classes, jmh-generated-sources) fix broken jmh metadata files (BenchmarkList, CompilerHints) fix jmh command line jar (inline dependencies with shadow plugin) fix jmh task for root scope (stop generate dummy jar) cleanup redundant out directory generated by IDEA remove slf4j and log4j dependencies (replace with slf4j-nop logger) add visual jmh report
upgrade gradle to version 4.2 change distribution type to binary
upgrade google-java-format to version 1.4
Member
|
If you submit this at the top of the stack, I'll accept. Otherwise will wait for any feedback from Robert on the other PR first. |
Contributor
Author
|
Let's await for review #401 |
Member
|
Can you refactor without splitting up the gradle file? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upgrade google-java-format to version 1.4