Add a document page to build on Windows.#887
Open
kimsama wants to merge 1 commit intorsocket:masterfrom
Open
Conversation
- modified CMakeLists.txt to resolve build errors. - excluded benchmark stuff to resolve platform issue. (I don't believe 'benchmarks' can be built on Windows because it's code uses POXIS socket library)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides adding a document file:
Motivation and Context
No document about build on Windows. Related issue #886
(Sorry for the direct tackle on master rather than using a branch but there might be no harm because it's just adding a document page and small changes of CMakeList.txt only effect on Windows)
How Has This Been Tested
Tested on Visual Studio 2017 v15.9.11 in Windows10.
Types of changes
Checklist