Delete FrameBufferAllocator#712
Merged
alexmalyshev merged 1 commit intorsocket:masterfrom Sep 5, 2017
alexmalyshev:delete-frame-buffer-allocator
Merged
Delete FrameBufferAllocator#712alexmalyshev merged 1 commit intorsocket:masterfrom alexmalyshev:delete-frame-buffer-allocator
alexmalyshev merged 1 commit intorsocket:masterfrom
alexmalyshev:delete-frame-buffer-allocator
Conversation
lehecka
approved these changes
Sep 1, 2017
This was planned on being passed into FrameSerializer so we could have the serializer allocate frames with extra headroom for the frame length if needed. This shouldn't be hidden by an external allocator however. If we're adding frame lengths, then the frame serializer should know about it and it should be the one serializing and deserializing them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was planned on being passed into FrameSerializer so we could have the
serializer allocate frames with extra headroom for the frame length if needed.
This shouldn't be hidden by an external allocator however. If we're adding
frame lengths, then the frame serializer should know about it and it should be
the one serializing and deserializing them.