Skip to content

Document that using assert() is frowned upon #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DemiMarie wants to merge 1 commit into from
Closed

Document that using assert() is frowned upon #1807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,10 @@ and friends. These never return NULL (they abort the process on failure),
so do not check for it. Also ll "destructor" type functions in rpm accept
NULL arguments, don't check for it separately.

Avoid using assert(). Instead, handle the error gracefully. For instance,
a function that verifies signatures should consider a NULL signature to be
invalid, just like a malformed non-NULL signature.

### Miscellaneous

While many details differ and lot of it does not apply at all, the [Linux
Expand Down