Conversation
seth-mg
reviewed
Feb 10, 2026
| </dependency> | ||
| <dependency> | ||
| <groupId>com.squareup</groupId> | ||
| <groupId>com.palantir.javapoet</groupId> |
Contributor
There was a problem hiding this comment.
Despite what their README says, this is still likely provided scope, right? I imagine it's usage is limited to pre-compilation.
Collaborator
Author
There was a problem hiding this comment.
It seems to need to be compile scope. Otherwise, the build fails:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.1:compile (default-compile) on project rosette-api-model: Fatal error compiling: java.lang.NoClassDefFoundError: com/palantir/javapoet/TypeSpec: com.palantir.javapoet.TypeSpec -> [Help 1]
Contributor
There was a problem hiding this comment.
Ah, I should have tried it first. 🤦♂️
seth-mg
reviewed
Feb 10, 2026
annotations/pom.xml
Outdated
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- | ||
| Copyright 2017-2024 Basis Technology Corp. | ||
| Copyright 2017-2026 Basis Technology Corp. |
Contributor
There was a problem hiding this comment.
I think the copyright should be updated to Babel Street Rosette Ltd. as we touch files.
juliencherry
force-pushed
the
COMN-422
branch
from
41f6df9 to
41e2403
Compare
juliencherry
force-pushed
the
COMN-422
branch
from
41e2403 to
17b905c
Compare
seth-mg
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.