[Noetic] Update RViz import#60
Merged
wjwwood merged 1 commit intoMay 13, 2020
Merged
Conversation
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
wjwwood
approved these changes
May 13, 2020
Author
|
@wjwwood oops it looks like this one got merged into |
Member
|
You’re right. I’ll fix that today. I didn’t release into kinetic or melodic yet though. |
Member
|
I fixed kinetic-devel, created noetic-devel, and released everything again: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the import of the rviz bindings as described here in the Noetic Migration guide. Without this the script fails to find
rviz.VisualizationFrame(). This change must be merged into a to-be-creatednoetic-develbranch, and notkinetic-devel.I'm currently unable to verify the rest of the script works because I'm unable to launch RViz in a container, but it may just be a problem with my container setup.