Skip to content

Conversation

@danielmorell
Copy link
Collaborator

@danielmorell danielmorell commented Jul 29, 2022

Description of the change

By catching only instances or instances of subclasses of Exception. We will not catch any Error instances that may be thrown. As a general rule, if the desire is to catch Exceptions it is best to catch Throwable. This PR simply updates Exception to Throwable. For more details on the specific issue see #51.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell merged commit 16615fa into next/5.x/main Jul 29, 2022
@danielmorell danielmorell deleted the fixed/issue-51 branch July 29, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants