forked from npgsql/npgsql
-
Notifications
You must be signed in to change notification settings - Fork 3
Expand file tree
/
Copy pathTransactionTests.cs
More file actions
669 lines (583 loc) · 26.7 KB
/
TransactionTests.cs
File metadata and controls
669 lines (583 loc) · 26.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
using System;
using System.Data;
using System.Threading.Tasks;
using Npgsql.Internal;
using Npgsql.Tests.Support;
using Npgsql.Util;
using NUnit.Framework;
using static Npgsql.Tests.TestUtil;
// ReSharper disable MethodHasAsyncOverload
// ReSharper disable UseAwaitUsing
namespace Npgsql.Tests;
public class TransactionTests : TestBase
{
[Test, Description("Basic insert within a committed transaction")]
public async Task Commit([Values(PrepareOrNot.NotPrepared, PrepareOrNot.Prepared)] PrepareOrNot prepare)
{
await using var conn = await OpenConnectionAsync();
var table = await CreateTempTable(conn, "name TEXT");
var tx = await conn.BeginTransactionAsync();
await using (tx)
{
var cmd = new NpgsqlCommand($"INSERT INTO {table} (name) VALUES ('X')", conn, tx);
if (prepare == PrepareOrNot.Prepared)
cmd.Prepare();
cmd.ExecuteNonQuery();
Assert.That(conn.ExecuteScalar($"SELECT COUNT(*) FROM {table}"), Is.EqualTo(1));
tx.Commit();
Assert.That(tx.IsCompleted);
Assert.That(() => tx.Connection, Throws.Nothing);
Assert.That(await conn.ExecuteScalarAsync($"SELECT COUNT(*) FROM {table}"), Is.EqualTo(1));
}
Assert.That(() => tx.Connection, Throws.Exception.TypeOf<ObjectDisposedException>());
}
[Test, Description("Basic insert within a committed transaction")]
public async Task CommitAsync([Values(PrepareOrNot.NotPrepared, PrepareOrNot.Prepared)] PrepareOrNot prepare)
{
await using var conn = await OpenConnectionAsync();
var table = await CreateTempTable(conn, "name TEXT");
var tx = await conn.BeginTransactionAsync();
await using (tx)
{
var cmd = new NpgsqlCommand($"INSERT INTO {table} (name) VALUES ('X')", conn, tx);
if (prepare == PrepareOrNot.Prepared)
cmd.Prepare();
await cmd.ExecuteNonQueryAsync();
Assert.That(conn.ExecuteScalar($"SELECT COUNT(*) FROM {table}"), Is.EqualTo(1));
await tx.CommitAsync();
Assert.That(tx.IsCompleted);
Assert.That(() => tx.Connection, Throws.Nothing);
Assert.That(await conn.ExecuteScalarAsync($"SELECT COUNT(*) FROM {table}"), Is.EqualTo(1));
}
Assert.That(() => tx.Connection, Throws.Exception.TypeOf<ObjectDisposedException>());
}
[Test, Description("Basic insert within a rolled back transaction")]
public async Task Rollback([Values(PrepareOrNot.NotPrepared, PrepareOrNot.Prepared)] PrepareOrNot prepare)
{
await using var conn = await OpenConnectionAsync();
var table = await CreateTempTable(conn, "name TEXT");
var tx = await conn.BeginTransactionAsync();
await using (tx)
{
var cmd = new NpgsqlCommand($"INSERT INTO {table} (name) VALUES ('X')", conn, tx);
if (prepare == PrepareOrNot.Prepared)
cmd.Prepare();
cmd.ExecuteNonQuery();
Assert.That(conn.ExecuteScalar($"SELECT COUNT(*) FROM {table}"), Is.EqualTo(1));
tx.Rollback();
Assert.That(tx.IsCompleted);
Assert.That(() => tx.Connection, Throws.Nothing);
Assert.That(await conn.ExecuteScalarAsync($"SELECT COUNT(*) FROM {table}"), Is.EqualTo(0));
}
Assert.That(() => tx.Connection, Throws.Exception.TypeOf<ObjectDisposedException>());
}
[Test, Description("Basic insert within a rolled back transaction")]
public async Task RollbackAsync([Values(PrepareOrNot.NotPrepared, PrepareOrNot.Prepared)] PrepareOrNot prepare)
{
await using var conn = await OpenConnectionAsync();
var table = await CreateTempTable(conn, "name TEXT");
var tx = await conn.BeginTransactionAsync();
await using (tx)
{
var cmd = new NpgsqlCommand($"INSERT INTO {table} (name) VALUES ('X')", conn, tx);
if (prepare == PrepareOrNot.Prepared)
cmd.Prepare();
await cmd.ExecuteNonQueryAsync();
Assert.That(conn.ExecuteScalar($"SELECT COUNT(*) FROM {table}"), Is.EqualTo(1));
await tx.RollbackAsync();
Assert.That(tx.IsCompleted);
Assert.That(() => tx.Connection, Throws.Nothing);
Assert.That(await conn.ExecuteScalarAsync($"SELECT COUNT(*) FROM {table}"), Is.EqualTo(0));
}
Assert.That(() => tx.Connection, Throws.Exception.TypeOf<ObjectDisposedException>());
}
[Test, Description("Dispose a transaction in progress, should roll back")]
public async Task Rollback_on_Dispose()
{
await using var conn = await OpenConnectionAsync();
var table = await CreateTempTable(conn, "name TEXT");
await using (var tx = await conn.BeginTransactionAsync())
{
await conn.ExecuteNonQueryAsync($"INSERT INTO {table} (name) VALUES ('X')", tx: tx);
}
Assert.That(await conn.ExecuteScalarAsync($"SELECT COUNT(*) FROM {table}"), Is.EqualTo(0));
}
[Test]
public async Task Rollback_on_Close()
{
await using var conn1 = await OpenConnectionAsync();
var table = await CreateTempTable(conn1, "name TEXT");
using (var conn2 = await OpenConnectionAsync())
{
var tx = await conn2.BeginTransactionAsync();
await conn2.ExecuteNonQueryAsync($"INSERT INTO {table} (name) VALUES ('X')", tx);
}
Assert.That(await conn1.ExecuteScalarAsync($"SELECT COUNT(*) FROM {table}"), Is.EqualTo(0));
}
[Test, Description("Intentionally generates an error, putting us in a failed transaction block. Rolls back.")]
public async Task Rollback_failed()
{
await using var conn = await OpenConnectionAsync();
var table = await CreateTempTable(conn, "name TEXT");
await using var tx = await conn.BeginTransactionAsync();
await conn.ExecuteNonQueryAsync($"INSERT INTO {table} (name) VALUES ('X')", tx: tx);
Assert.That(async () => await conn.ExecuteNonQueryAsync("BAD QUERY"), Throws.Exception.TypeOf<PostgresException>());
tx.Rollback();
Assert.That(tx.IsCompleted);
Assert.That(await conn.ExecuteScalarAsync($"SELECT COUNT(*) FROM {table}"), Is.EqualTo(0));
}
[Test, Description("Commits an empty transaction")]
public async Task Empty_commit()
{
await using var conn = await OpenConnectionAsync();
await conn.BeginTransaction().CommitAsync();
}
[Test, Description("Rolls back an empty transaction")]
public async Task Empty_rollback()
{
await using var conn = await OpenConnectionAsync();
await conn.BeginTransaction().RollbackAsync();
}
[Test, Description("Disposes an empty transaction")]
public async Task Empty_Dispose()
{
await using var dataSource = CreateDataSource();
using (var conn = await dataSource.OpenConnectionAsync())
using (conn.BeginTransaction())
{ }
using (var conn = await dataSource.OpenConnectionAsync())
{
// Make sure the pending BEGIN TRANSACTION didn't leak from the previous open
Assert.That(async () => await conn.ExecuteNonQueryAsync("SAVEPOINT foo"),
Throws.Exception.TypeOf<PostgresException>()
.With.Property(nameof(PostgresException.SqlState)).EqualTo(PostgresErrorCodes.NoActiveSqlTransaction));
}
}
[Test, Description("Tests that the isolation levels are properly supported")]
[TestCase(IsolationLevel.ReadCommitted, "read committed")]
[TestCase(IsolationLevel.ReadUncommitted, "read uncommitted")]
[TestCase(IsolationLevel.RepeatableRead, "repeatable read")]
[TestCase(IsolationLevel.Serializable, "serializable")]
[TestCase(IsolationLevel.Snapshot, "repeatable read")]
[TestCase(IsolationLevel.Unspecified, "read committed")]
public async Task Isolation_levels(IsolationLevel level, string expectedName)
{
await using var conn = await OpenConnectionAsync();
var tx = conn.BeginTransaction(level);
Assert.That(conn.ExecuteScalar("SHOW TRANSACTION ISOLATION LEVEL"), Is.EqualTo(expectedName));
await tx.CommitAsync();
}
[Test]
public async Task IsolationLevel_Chaos_is_unsupported()
{
await using var conn = await OpenConnectionAsync();
Assert.That(() => conn.BeginTransaction(IsolationLevel.Chaos), Throws.Exception.TypeOf<NotSupportedException>());
}
[Test, Description("Rollback of an already rolled back transaction")]
public async Task Rollback_twice()
{
await using var conn = await OpenConnectionAsync();
var transaction = conn.BeginTransaction();
transaction.Rollback();
Assert.That(() => transaction.Rollback(), Throws.Exception.TypeOf<InvalidOperationException>());
}
[Test, Description("Makes sure the creating a transaction via DbConnection sets the proper isolation level")]
[IssueLink("https://github.com/npgsql/npgsql/issues/559")]
public async Task Default_IsolationLevel()
{
await using var conn = await OpenConnectionAsync();
var tx = conn.BeginTransaction();
Assert.That(tx.IsolationLevel, Is.EqualTo(IsolationLevel.ReadCommitted));
tx.Rollback();
tx = conn.BeginTransaction(IsolationLevel.Unspecified);
Assert.That(tx.IsolationLevel, Is.EqualTo(IsolationLevel.ReadCommitted));
tx.Rollback();
}
[Test, Description("Makes sure that transactions started in SQL work")]
public async Task Via_sql()
{
await using var conn = await OpenConnectionAsync();
var table = await CreateTempTable(conn, "name TEXT");
await conn.ExecuteNonQueryAsync("BEGIN");
await conn.ExecuteNonQueryAsync($"INSERT INTO {table} (name) VALUES ('X')");
await conn.ExecuteNonQueryAsync("ROLLBACK");
Assert.That(conn.ExecuteScalar($"SELECT COUNT(*) FROM {table}"), Is.EqualTo(0));
}
[Test]
public async Task Nested()
{
await using var conn = await OpenConnectionAsync();
conn.BeginTransaction();
Assert.That(() => conn.BeginTransaction(), Throws.TypeOf<InvalidOperationException>());
}
[Test]
public void Begin_transaction_on_closed_connection_throws()
{
using var conn = new NpgsqlConnection();
Assert.That(() => conn.BeginTransaction(), Throws.Exception.TypeOf<InvalidOperationException>());
}
[Test]
public async Task Rollback_failed_transaction_with_timeout()
{
await using var conn = await OpenConnectionAsync();
var tx = conn.BeginTransaction();
using var cmd = new NpgsqlCommand("BAD QUERY", conn, tx);
Assert.That(cmd.CommandTimeout != 1);
cmd.CommandTimeout = 1;
try
{
cmd.ExecuteScalar();
Assert.Fail();
}
catch (PostgresException)
{
// Timeout at the backend is now 1
await tx.RollbackAsync();
Assert.That(await conn.ExecuteScalarAsync("SELECT 1"), Is.EqualTo(1));
}
}
[Test, Description("If a custom command timeout is set, a failed transaction could not be rollbacked to a previous savepoint")]
[IssueLink("https://github.com/npgsql/npgsql/issues/363")]
[IssueLink("https://github.com/npgsql/npgsql/issues/184")]
public async Task Failed_transaction_cannot_rollback_to_savepoint_with_custom_timeout()
{
await using var conn = await OpenConnectionAsync();
var transaction = conn.BeginTransaction();
transaction.Save("TestSavePoint");
using var cmd = new NpgsqlCommand("SELECT unknown_thing", conn);
cmd.CommandTimeout = 1;
try
{
cmd.ExecuteScalar();
}
catch (PostgresException)
{
transaction.Rollback("TestSavePoint");
Assert.That(conn.ExecuteScalar("SELECT 1"), Is.EqualTo(1));
}
}
[Test, Description("Closes a (pooled) connection with a failed transaction and a custom timeout")]
[IssueLink("https://github.com/npgsql/npgsql/issues/719")]
public async Task Failed_transaction_on_close_with_custom_timeout()
{
await using var dataSource = CreateDataSource(csb => csb.Pooling = true);
await using var conn = await dataSource.OpenConnectionAsync();
conn.BeginTransaction();
var backendProcessId = conn.ProcessID;
using (var badCmd = new NpgsqlCommand("SEL", conn))
{
badCmd.CommandTimeout = NpgsqlCommand.DefaultTimeout + 1;
Assert.That(() => badCmd.ExecuteNonQuery(), Throws.Exception.TypeOf<PostgresException>());
}
// Connection now in failed transaction state, and a custom timeout is in place
conn.Close();
conn.Open();
conn.BeginTransaction();
Assert.That(conn.ProcessID, Is.EqualTo(backendProcessId));
Assert.That(conn.ExecuteScalar("SELECT 1"), Is.EqualTo(1));
}
[Test, IssueLink("https://github.com/npgsql/npgsql/issues/555")]
public async Task Transaction_on_recycled_connection()
{
// Use application name to make sure we have our very own private connection pool
await using var conn = new NpgsqlConnection(ConnectionString + $";Application Name={GetUniqueIdentifier(nameof(Transaction_on_recycled_connection))}");
conn.Open();
var prevConnectorId = conn.Connector!.Id;
conn.Close();
conn.Open();
Assert.That(conn.Connector.Id, Is.EqualTo(prevConnectorId), "Connection pool returned a different connector, can't test");
var tx = conn.BeginTransaction();
conn.ExecuteScalar("SELECT 1");
await tx.CommitAsync();
NpgsqlConnection.ClearPool(conn);
}
[Test]
public async Task Savepoint()
{
await using var conn = await OpenConnectionAsync();
var table = await CreateTempTable(conn, "name TEXT");
const string name = "theSavePoint";
using (var tx = conn.BeginTransaction())
{
tx.Save(name);
await conn.ExecuteNonQueryAsync($"INSERT INTO {table} (name) VALUES ('savepointtest')", tx: tx);
Assert.That(conn.ExecuteScalar($"SELECT COUNT(*) FROM {table}", tx: tx), Is.EqualTo(1));
tx.Rollback(name);
Assert.That(conn.ExecuteScalar($"SELECT COUNT(*) FROM {table}", tx: tx), Is.EqualTo(0));
await conn.ExecuteNonQueryAsync($"INSERT INTO {table} (name) VALUES ('savepointtest')", tx: tx);
tx.Release(name);
Assert.That(conn.ExecuteScalar($"SELECT COUNT(*) FROM {table}", tx: tx), Is.EqualTo(1));
await tx.CommitAsync();
}
Assert.That(await conn.ExecuteScalarAsync($"SELECT COUNT(*) FROM {table}"), Is.EqualTo(1));
}
[Test]
public async Task Savepoint_async()
{
await using var conn = await OpenConnectionAsync();
var table = await CreateTempTable(conn, "name TEXT");
const string name = "theSavePoint";
using (var tx = conn.BeginTransaction())
{
await tx.SaveAsync(name);
await conn.ExecuteNonQueryAsync($"INSERT INTO {table} (name) VALUES ('savepointtest')", tx: tx);
Assert.That(conn.ExecuteScalar($"SELECT COUNT(*) FROM {table}", tx: tx), Is.EqualTo(1));
await tx.RollbackAsync(name);
Assert.That(conn.ExecuteScalar($"SELECT COUNT(*) FROM {table}", tx: tx), Is.EqualTo(0));
await conn.ExecuteNonQueryAsync($"INSERT INTO {table} (name) VALUES ('savepointtest')", tx: tx);
await tx.ReleaseAsync(name);
Assert.That(conn.ExecuteScalar($"SELECT COUNT(*) FROM {table}", tx: tx), Is.EqualTo(1));
await tx.CommitAsync();
}
Assert.That(await conn.ExecuteScalarAsync($"SELECT COUNT(*) FROM {table}"), Is.EqualTo(1));
}
[Test]
public async Task Savepoint_quoted()
{
await using var conn = await OpenConnectionAsync();
await using var tx = conn.BeginTransaction();
tx.Save("a;b");
tx.Rollback("a;b");
}
[Test(Description = "Makes sure that creating a savepoint doesn't perform an additional roundtrip, but prepends to the next command")]
public async Task Savepoint_prepends()
{
await using var postmasterMock = PgPostmasterMock.Start(ConnectionString);
await using var dataSource = CreateDataSource(postmasterMock.ConnectionString);
await using var conn = await dataSource.OpenConnectionAsync();
var pgMock = await postmasterMock.WaitForServerConnection();
using var tx = conn.BeginTransaction();
var saveTask = tx.SaveAsync("foo");
Assert.That(saveTask.Status, Is.EqualTo(TaskStatus.RanToCompletion));
// If we're here, SaveAsync above didn't wait for any response, which is the right behavior
await pgMock
.WriteCommandComplete()
.WriteReadyForQuery() // BEGIN response
.WriteCommandComplete()
.WriteReadyForQuery() // SAVEPOINT response
.WriteScalarResponseAndFlush(1);
await conn.ExecuteScalarAsync("SELECT 1");
await pgMock.ExpectSimpleQuery("BEGIN TRANSACTION ISOLATION LEVEL READ COMMITTED");
await pgMock.ExpectSimpleQuery("SAVEPOINT foo");
await pgMock.ExpectExtendedQuery();
}
[Test, Description("Check IsCompleted before, during and after a normal committed transaction")]
[IssueLink("https://github.com/npgsql/npgsql/issues/985")]
public async Task IsCompleted_commit()
{
await using var conn = await OpenConnectionAsync();
var table = await CreateTempTable(conn, "name TEXT");
var tx = conn.BeginTransaction();
Assert.That(!tx.IsCompleted);
await conn.ExecuteNonQueryAsync($"INSERT INTO {table} (name) VALUES ('X')", tx: tx);
Assert.That(!tx.IsCompleted);
await tx.CommitAsync();
Assert.That(tx.IsCompleted);
}
[Test, Description("Check IsCompleted before, during, and after a successful but rolled back transaction")]
[IssueLink("https://github.com/npgsql/npgsql/issues/985")]
public async Task IsCompleted_rollback()
{
await using var conn = await OpenConnectionAsync();
var table = await CreateTempTable(conn, "name TEXT");
var tx = conn.BeginTransaction();
Assert.That(!tx.IsCompleted);
await conn.ExecuteNonQueryAsync($"INSERT INTO {table} (name) VALUES ('X')", tx: tx);
Assert.That(!tx.IsCompleted);
tx.Rollback();
Assert.That(tx.IsCompleted);
}
[Test, Description("Check IsCompleted before, during, and after a failed then rolled back transaction")]
[IssueLink("https://github.com/npgsql/npgsql/issues/985")]
public async Task IsCompleted_rollback_failed()
{
await using var conn = await OpenConnectionAsync();
var table = await CreateTempTable(conn, "name TEXT");
var tx = conn.BeginTransaction();
Assert.That(!tx.IsCompleted);
await conn.ExecuteNonQueryAsync($"INSERT INTO {table} (name) VALUES ('X')", tx: tx);
Assert.That(!tx.IsCompleted);
Assert.That(async () => await conn.ExecuteNonQueryAsync("BAD QUERY"), Throws.Exception.TypeOf<PostgresException>());
Assert.That(!tx.IsCompleted);
tx.Rollback();
Assert.That(tx.IsCompleted);
Assert.That(await conn.ExecuteScalarAsync($"SELECT COUNT(*) FROM {table}"), Is.EqualTo(0));
}
[Test, Description("Tests that a if a DatabaseInfoFactory is registered for a database that doesn't support transactions, no transactions are created")]
[Parallelizable(ParallelScope.None)]
public async Task Transaction_not_supported()
{
// TODO: rewrite to DataSource
var connString = new NpgsqlConnectionStringBuilder(ConnectionString)
{
ApplicationName = nameof(Transaction_not_supported)
}.ToString();
NpgsqlDatabaseInfo.RegisterFactory(new NoTransactionDatabaseInfoFactory());
try
{
using var conn = new NpgsqlConnection(connString);
await conn.OpenAsync();
using var tx = conn.BeginTransaction();
// Detect that we're not really in a transaction
var prevTxId = conn.ExecuteScalar("SELECT txid_current()");
var nextTxId = conn.ExecuteScalar("SELECT txid_current()");
// If we're in an actual transaction, the two IDs should be the same
// https://stackoverflow.com/questions/1651219/how-to-check-for-pending-operations-in-a-postgresql-transaction
Assert.That(nextTxId, Is.Not.EqualTo(prevTxId));
conn.Close();
}
finally
{
NpgsqlDatabaseInfo.ResetFactories();
}
using (var conn = new NpgsqlConnection(connString))
{
await conn.OpenAsync();
NpgsqlConnection.ClearPool(conn);
conn.ReloadTypes();
}
// Check that everything is back to normal
using (var conn = new NpgsqlConnection(connString))
{
await conn.OpenAsync();
using (var tx = conn.BeginTransaction())
{
var prevTxId = conn.ExecuteScalar("SELECT txid_current()");
var nextTxId = conn.ExecuteScalar("SELECT txid_current()");
Assert.That(nextTxId, Is.EqualTo(prevTxId));
}
}
}
[Test]
[IssueLink("https://github.com/npgsql/npgsql/issues/3306")]
[TestCase(true)]
[TestCase(false)]
public async Task Bug3306(bool inTransactionBlock)
{
var conn = await OpenConnectionAsync();
var tx = await conn.BeginTransactionAsync();
await conn.ExecuteNonQueryAsync("SELECT 1", tx);
if (!inTransactionBlock)
await tx.RollbackAsync();
await conn.CloseAsync();
conn = await OpenConnectionAsync();
var tx2 = await conn.BeginTransactionAsync();
await tx.DisposeAsync();
Assert.That(tx.IsDisposed, Is.True);
Assert.That(tx2.IsDisposed, Is.False);
await conn.DisposeAsync();
}
[Test, IssueLink("https://github.com/npgsql/efcore.pg/issues/1593")]
public async Task Access_connection_on_completed_transaction()
{
using var conn = await OpenConnectionAsync();
using var tx = await conn.BeginTransactionAsync();
tx.Commit();
Assert.That(tx.Connection, Is.SameAs(conn));
}
[Test]
public async Task Unbound_transaction_reuse()
{
await using var dataSource = CreateDataSource(csb =>
{
csb.MinPoolSize = 1;
csb.MaxPoolSize = 1;
});
await using var conn = await OpenConnectionAsync();
var table = await CreateTempTable(conn, "name TEXT");
await using var conn1 = await dataSource.OpenConnectionAsync();
var tx1 = conn1.BeginTransaction();
await using (var ___ = tx1)
{
using var cmd1 = conn1.CreateCommand();
cmd1.CommandText = $"INSERT INTO {table} (name) VALUES ('X'); SELECT 1";
await using (var reader1 = await cmd1.ExecuteReaderAsync())
{
Assert.That(async () => await reader1.ReadAsync(), Is.EqualTo(true));
Assert.That(() => reader1.GetInt32(0), Is.EqualTo(1));
Assert.That(reader1.RecordsAffected, Is.EqualTo(1));
}
await tx1.CommitAsync();
Assert.That(await conn1.ExecuteScalarAsync($"SELECT COUNT(*) FROM {table}"), Is.EqualTo(1));
await conn1.CloseAsync();
}
await using var conn2 = await dataSource.OpenConnectionAsync();
var tx2 = conn2.BeginTransaction();
await using (var ___ = tx2)
{
Assert.That(tx2, Is.Not.SameAs(tx1));
using var cmd2 = conn2.CreateCommand();
cmd2.CommandText = $"INSERT INTO {table} (name) VALUES ('Y'); SELECT 2";
await using (var reader2 = await cmd2.ExecuteReaderAsync())
{
Assert.That(async () => await reader2.ReadAsync(), Is.EqualTo(true));
Assert.That(() => reader2.GetInt32(0), Is.EqualTo(2));
Assert.That(reader2.RecordsAffected, Is.EqualTo(1));
}
await tx2.CommitAsync();
Assert.That(await conn2.ExecuteScalarAsync($"SELECT COUNT(*) FROM {table}"), Is.EqualTo(2));
await conn2.CloseAsync();
}
await using var conn3 = await dataSource.OpenConnectionAsync();
var tx3 = conn3.BeginTransaction();
await using (var ___ = tx3)
{
Assert.That(tx3, Is.SameAs(tx1));
using var cmd3 = conn3.CreateCommand();
cmd3.CommandText = $"INSERT INTO {table} (name) VALUES ('Z'); SELECT 3";
await using (var reader3 = await cmd3.ExecuteReaderAsync())
{
Assert.That(async () => await reader3.ReadAsync(), Is.EqualTo(true));
Assert.That(() => reader3.GetInt32(0), Is.EqualTo(3));
Assert.That(reader3.RecordsAffected, Is.EqualTo(1));
}
await tx3.CommitAsync();
Assert.That(await conn3.ExecuteScalarAsync($"SELECT COUNT(*) FROM {table}"), Is.EqualTo(3));
await conn3.CloseAsync();
}
}
[Test, IssueLink("https://github.com/npgsql/npgsql/issues/3686")]
public async Task Bug3686()
{
await using var dataSource = CreateDataSource(csb => csb.Pooling = false);
await using var conn = await dataSource.OpenConnectionAsync();
await using var tx = await conn.BeginTransactionAsync();
await conn.ExecuteNonQueryAsync("SELECT 1", tx);
await tx.CommitAsync();
await conn.CloseAsync();
Assert.DoesNotThrow(() =>
{
_ = tx.Connection;
});
}
class NoTransactionDatabaseInfoFactory : INpgsqlDatabaseInfoFactory
{
public async Task<NpgsqlDatabaseInfo?> Load(NpgsqlConnector conn, NpgsqlTimeout timeout, bool async)
{
var db = new NoTransactionDatabaseInfo(conn);
await db.LoadPostgresInfo(conn, timeout, async);
return db;
}
}
class NoTransactionDatabaseInfo : PostgresDatabaseInfo
{
public override bool SupportsTransactions => false;
internal NoTransactionDatabaseInfo(NpgsqlConnector conn) : base(conn) {}
}
// Older tests
[Test]
public void Bug184_Rollback_fails_on_aborted_transaction()
{
var csb = new NpgsqlConnectionStringBuilder(ConnectionString);
csb.CommandTimeout = 100000;
using var connTimeoutChanged = new NpgsqlConnection(csb.ToString());
connTimeoutChanged.Open();
using var t = connTimeoutChanged.BeginTransaction();
try {
var command = new NpgsqlCommand("select count(*) from dta", connTimeoutChanged, t);
_ = command.ExecuteScalar();
} catch (Exception) {
t.Rollback();
}
}
}