Skip to content

Add new Dir features #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Anton-4 merged 9 commits into from
Aug 8, 2023
Merged

Add new Dir features #97

Anton-4 merged 9 commits into from
Aug 8, 2023

Conversation

@lukewilliamboswell
Copy link
Collaborator

@lukewilliamboswell lukewilliamboswell commented Aug 6, 2023

This PR

  • Adds Dir.make
  • Adds Dir.makeRecursive
  • Implements Dir.deleteEmptyDir
  • Implements Dir.deleteRecursive
  • Adds a CI test for the Dir module
  • Simplifies error handling into a single IOError type to align closer to Rust std::io::ErrorKind

Anton-4
Anton-4 requested changes Aug 7, 2023
View reviewed changes
Anton-4
Anton-4 approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@Anton-4 Anton-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @lukewilliamboswell :)

@Anton-4 Anton-4 merged commit 3c8a526 into roc-lang:main Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Anton-4 Anton-4 Anton-4 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lukewilliamboswell @Anton-4