Skip to content

Fix incorrectly placed ? operator in Path module#319

Merged
smores56 merged 3 commits intoroc-lang:mainfrom
imclerran:fix-invalid-try
Jan 27, 2025
Merged

Fix incorrectly placed ? operator in Path module#319
smores56 merged 3 commits intoroc-lang:mainfrom
imclerran:fix-invalid-try

Conversation

@imclerran
Copy link
Contributor

@imclerran imclerran commented Jan 27, 2025

Path.roc had an invalid use of the ? operator. This should be placed after the last paren on the function call, instead of before the opening paren.

Screenshot 2025-01-27 at 09 38 26

smores56
smores56 previously approved these changes Jan 27, 2025
@imclerran
Copy link
Contributor Author

Looks like CI does not have roc-lang/roc#7548

@Anton-4
Copy link
Collaborator

Anton-4 commented Jan 27, 2025

Can you do nix flake update followed by nix develop and push again @imclerran?

@smores56 smores56 merged commit fae5769 into roc-lang:main Jan 27, 2025
5 checks passed
@imclerran imclerran deleted the fix-invalid-try branch January 27, 2025 17:29
@imclerran imclerran changed the title Replace invalid ? operator with try Fix incorrectly placed ? operator in Path module Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants