Updates to doc comments, and export to make doc gen work#28
Merged
rtfeldman merged 5 commits intoroc-lang:mainfrom Jun 10, 2023
Merged
Updates to doc comments, and export to make doc gen work#28rtfeldman merged 5 commits intoroc-lang:mainfrom
rtfeldman merged 5 commits intoroc-lang:mainfrom
Conversation
Collaborator
Author
|
I hadn't noticed @rtfeldman PR #22 this does basically the same thing, but also add instructions to the README and some formatting edits to the modules Doc comments. |
Collaborator
Collaborator
Author
|
If we merge #22 first, then I will update this so that when we generate the docs they look acceptable. There is a lot of missing doc comments, but at least what is there will be more useable. |
Collaborator
|
I didn't notice it until later but it looks like the exposes issue is fixed? |
Collaborator
|
It does appear to be stuck again on env again in #22, EDIT |
rtfeldman
reviewed
Jun 10, 2023
rtfeldman
reviewed
Jun 10, 2023
rtfeldman
approved these changes
Jun 10, 2023
Contributor
rtfeldman
left a comment
rtfeldman
left a comment
There was a problem hiding this comment.
Awesome, super excited about this!!! 😍 😍 😍
I added a couple of comments, but nothing blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor updates to get docs generation working for
basic-cli.@Anton-4 I wasn't sure if there is a reason the modules aren't exposed in the platform
main.roc. I added them anyway so docs generation would work. Please let me know if this is not right.