Merged
Conversation
Anton-4
commented
Jan 17, 2023
| use glue::Metadata; | ||
| use roc_std::{RocDict, RocList, RocResult, RocStr}; | ||
| use std::borrow::{Borrow, Cow}; | ||
| use std::ffi::{CStr, OsStr}; |
Anton-4
commented
Jan 17, 2023
| use std::ffi::{OsStr}; | ||
| use std::fs::File; | ||
| use std::io::Write; | ||
| use std::os::raw::c_char; |
Anton-4
commented
Jan 17, 2023
Comment on lines
-108
to
-113
| #[cfg(unix)] | ||
| #[no_mangle] | ||
| pub unsafe extern "C" fn roc_send_signal(pid: libc::pid_t, sig: libc::c_int) -> libc::c_int { | ||
| libc::kill(pid, sig) | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
this was also removed in the cli platform on the repo
Anton-4
commented
Jan 17, 2023
| platform "cli" | ||
| requires {} { main : Task {} [] } | ||
| exposes [Task, Process, Stdout, Stderr, Stdin, Path, File, FileMetadata, Dir, Arg, Env, EnvDecoding, Url, Http] | ||
| exposes [] |
Collaborator
Author
There was a problem hiding this comment.
@rtfeldman this fixes building env.roc and file.roc, but it may cause no docs to be generated? Also strangely, even though nothing is exposed, Task, Stdout, Stderr... can still be used by for example env.roc.
Collaborator
Author
There was a problem hiding this comment.
This also prevents the false positive import error from occurring that I talked to you about earlier:
── MODULE NOT IMPORTED ──── ../../basic-cli2/basic-cli/examples/../src/Env.roc ─
The `EnvDecoding` module is not imported:
78│ Decode.fromBytes (Str.toUtf8 varStr) (EnvDecoding.format {})
^^^^^^^^^^^^^^^^^^
Did you mean to import it?
────────────────────────────────────────────────────────────────────────────────
Which was caused by commit e549456
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.