EnvDecoding type matches changes to decoding from here: https://github.com/roc-lang/roc/pull/6587#176
Merged
Anton-4 merged 5 commits intoroc-lang:mainfrom Apr 12, 2024
Merged
Conversation
rtfeldman
previously approved these changes
Apr 8, 2024
Anton-4
previously approved these changes
Apr 9, 2024
Collaborator
|
@faldor20 I had to undo your change to the type signature of |
Collaborator
Author
|
I have no idea how I missed that. So sorry. That's correct @Anton-4 |
Collaborator
|
👍 No problem |
Anton-4
approved these changes
Apr 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR for optional record field decoding changes the type of the finalize function to take two args:
roc-lang/roc#6587
This updates the signature to match