Fixing type reference to self #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the fix! FWIW, I wrote a different C++ parser in python (https://github.com/robotpy/cxxheaderparser), and I'd encourage you to try it out. Once I finish migrating my tools over to it I'm going to deprecate this repo. Would love any feedback! |
Contributor
Author
|
Thanks! Will check it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a bug for some functions that reference the type itself. For instance, running the parser against the struct
Ashown below will result in a "Circular reference detected" during the JSON encoding step:This PR solves this issue by removing any circular references in the dictionary before passing to the JSON.