Added NotRun Keyword Remover functionality#5507
Open
DiegoGSBiondi wants to merge 1 commit into
Open
Conversation
pekkaklarck
requested changes
Oct 3, 2025
Member
pekkaklarck
left a comment
pekkaklarck
left a comment
There was a problem hiding this comment.
Few things to be done:
- As I mentioned in the separate comment, the current implementation removes keywords only from test body, not from child keywords and control structures.
- Tests are needed.
atest/README.rstexplains the test system and I can help here or on the #devel channel on our Slack if you have questions. - User Guide documentation is needed. I can help with that as well if needed.
| def visit_test(self, test): | ||
| before = len(test.body) | ||
| test.body = [kw for kw in test.body if kw.status != "NOT RUN"] | ||
| self.removal_message.set_to_if_removed(test, before) |
Member
There was a problem hiding this comment.
This only removes keywords from test body, not from child keywords or control structures. The easiest way to extend the functionality would be implementing start_test instead of visit_test (that way also body is visited automatically) and implementing also start_body_item that's, by default, called with all keywords and control structures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanded functionality of "--removekeywords" to also remove keywords with the "NOT RUN" status as per the request in issue #3845.