Cleanup selecting windows. - #968
Merged
Merged
Conversation
Contains code and test changes related to robotframework#966. Documentation still missing.
Fixes robotframework#966. Documentation cleanup also related to robotframework#925.
aaltat
reviewed
Oct 28, 2017
| similarly as when `locating elements` on pages. | ||
|
|
||
| - By default the ``locator`` is matched against window handle, name, | ||
| title, and URL. Matching is done in that order and the the first |
Contributor
There was a problem hiding this comment.
Comma after word title is not needed.
Member
Author
There was a problem hiding this comment.
Not needed but recommended: http://www.getitwriteonline.com/archive/052709serialcomma.htm
| opens a new window. | ||
|
|
||
| Example: | ||
| | `Click Link` | popup1 | | # Open new window | |
Contributor
There was a problem hiding this comment.
Nitpick, should the tables be same size?
This was referenced Nov 2, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code and documentation cleanup to Select Window. Also add Get Window Handles to replace List Windows. See individual commit messages for more details. Ready for review.