Repository navigation
Fix unit tests on Python3 and keep them OK on Python2.7 - #720
HelioGuilherme66 wants to merge 1 commit into
Conversation
HelioGuilherme66
commented
Dec 19, 2016
HelioGuilherme66
commented
- Formatting of exceptions messages
- Definition of unicode method on Python 3.x
|
Please merge this one to have Travis builds green again. Later we can optimize the "unicode" in Python 3.x. |
|
The approach to handle unicode is not correct. It perhaps makes unit tests pass but it won't actually work correctly. Not sure yet what's the best solution to this, but committing broken implememtation wouldn't make sense. Actual unit test fixes could be done already now, but converting exceptions to strings should be done using |
|
This approach would be ok? |
|
Thanks from the link, need to read it with more thought. |
4bcb20e to
8651e7e
Compare
|
@pekkaklarck Please see if you agree with the TODAY's change to use |
|
No, I don't agree with them:
|
|
I have run out of ideas. Please post solution for the unicode problem. |
|
I'm not sure yet what's the best solution for handling unicode/str/bytes stuff in this library. The solution may in fact be different in different places, most importantly different in the real library code and in unit tests. I hope I have time for Se2Lib next week ,but I'll start from the architecture changes @aaltat and I have discussed. |
Defines unicode on Python 3.x to be compatible with Python 2.7.
8651e7e to
4658057
Compare
There are entries obsolete or overridden by others. The goal is to keep Selenium2Library compatible with Python 2.7 and 3.x. There is still discussion on the best way to solve compatability problems, like for example, 'unicode'. See https://github.com/robotframework/Selenium2Library/pull/720 for more info on this. Commits entries: Changes to Travis settings to allow installation dependent on Python versions. Transformed print statement into function. Compatible with Python 2.6. Fixes import to be compatible with RobotFramework 3.0. Changes Travis settings to install RobotFramework 3.0. Separates imports per line, for better code readability. Adds 'future' dependency and information to install it. Upgrades Travis firefox to latest-esr. Fixes ez_setup.py. Changes version to 1.8.0b2. Removes selenium version dependency, current version is 2.53.2. Add GitHub process files. Update CONTRIBUTING.md Fixed Issues URL to point to my fork. Update ISSUE_TEMPLATE.md Fix typo Libdoc updates - link to project and fix 404 (robotframework#668) * Fix 404 due to RF migration to Github * Link to project page * Format corrections per PR comments * fix pronoun usage Added method to find element by class name robotframework#673 (robotframework#674) * Added method to find element by class name robotframework#673 * Changes to use Firefox ESR (45.4.0) While we are not having Selenium 3.0 working, with external `geckodriver`, we use lower versions of stable Firefox. * Changes to use Selenium 2.53.6 (and not 3.0) We are not ready for Selenium 3.0 yet. Updated Travis config. Fixes installer for both Python 2.7 and 3.x.
|
This issue is already fixed in master, therefore closing the PR. |
