Repository navigation
Fixes installer for both Python 2.7 and 3.x. - #718
Merged
Merged
Conversation
Member
|
Why would be with open(join(CURDIR, 'src', 'Selenium2Library', 'version.py')) as f:
exec(f.read()) |
HelioGuilherme66
force-pushed
the
fix_installer
branch
from
December 19, 2016 10:29
41c5981 to
76bff8f
Compare
Member
Author
|
Modified code as @pekkaklarck suggestion. |
Contributor
|
Would you mind rebase with the current master. I would like to see that the change works with Python 2 and 3 with Travis. |
Simplifies exec version.py.
HelioGuilherme66
force-pushed
the
fix_installer
branch
from
January 11, 2017 23:14
76bff8f to
e76a701
Compare
Member
Author
|
Rebased (tests pass except on python 3.3). |
8 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces problematic execfile by exec.