Skip to content

Makes unit tests runner more compatible between operating systems - #693

Closed
HelioGuilherme66 wants to merge 2 commits into
robotframework:masterfrom
HelioGuilherme66:fix_unit_tests_runner2
Closed

HelioGuilherme66 wants to merge 2 commits into
robotframework:masterfrom
HelioGuilherme66:fix_unit_tests_runner2

Conversation

@HelioGuilherme66

Copy link
Copy Markdown
Member

Now calls run_unit_tests.py file instead of the method (this fixes failure in Fedora Core 22).
Get path to python/jython to run unit tests.

…ilure in Fedora Core 22).

Get path to python/jython to run unit tests.
@pekkaklarck

Copy link
Copy Markdown
Member

It is a good idea to run unit tests as an external process and not by directly calling run_unit_tests method. In the current approach unit tests are always executed by using the Python interpreter that runs run_tests.py script.

The implementation to run tests using sys.executable doesn't make much sense, though, because it ends up using the exact same interpreter that is used for running run_tests.py. There's also a problem that on Jython sys.executable may not always be set correctly.

A good way to accomplish the original goal would be using the given interpreter to run the unit tests. This should be done after the larger acceptance test cleanup done in PR #710, though. Or perhaps I could add this enhancement into that PR as well.

HelioGuilherme66 added a commit to HelioGuilherme66/robotframework-seleniumlibrary that referenced this pull request Dec 19, 2016
Removed "from future".
Contains proposal from "Makes unit tests runner more compatible between operating systems robotframework#693" (obsoletes it).
@HelioGuilherme66

Copy link
Copy Markdown
Member Author

Will need rewrite after merging #716.
(Will use --interpreter value)

@HelioGuilherme66

Copy link
Copy Markdown
Member Author

Closing in favor of #720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants