Skip to content

Added method to find element by class name #673 - #674

Merged
aaltat merged 3 commits into
robotframework:masterfrom
Gaurang033:branch1
Oct 14, 2016
Merged

aaltat merged 3 commits into
robotframework:masterfrom
Gaurang033:branch1

Conversation

@Gaurang033

Copy link
Copy Markdown
Contributor

Added a new locator strategy find by class name and unit test case for it.

@aaltat

aaltat commented Oct 14, 2016

Copy link
Copy Markdown
Contributor

I did restart the Travis build because it seems that the error is not related to your chances.

PR must also update the library documentation in here https://github.com/robotframework/Selenium2Library/blob/master/src/Selenium2Library/__init__.py Update the chapter which describes the locator strategies.

Usually it would be good idea to write acceptance test also. It would help to detect if the selenium interface changes.

@aaltat

aaltat commented Oct 14, 2016

Copy link
Copy Markdown
Contributor

The Travis build did fail again. Would you mind looking what the actual failure seems to be?

@Gaurang033

Gaurang033 commented Oct 14, 2016 •

Copy link
Copy Markdown
Contributor Author

Hi,

I just checked the logs, it seems like geckodriver execute path is not set,
Following is the error message. All the tests are passing locally.
WebDriverException: Message: 'geckodriver' executable needs to be in PATH.

On Fri, Oct 14, 2016 at 10:50 AM, Tatu Aalto notifications@github.com
wrote:

The Travis build did fail again. Would you mind looking what the actual
failure seems to be?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/robotframework/Selenium2Library/pull/674#issuecomment-253711934,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACf7ZfrgstAU4O4GpFiyKlnJaJWeaPmuks5qzxE3gaJpZM4KWmcW
.

@aaltat

aaltat commented Oct 14, 2016

Copy link
Copy Markdown
Contributor

Oh darn. In that case it seems that Travis did update the Firefox to a version which needs the geckodriver. Therefore it needs some work from the admin side. Have to take a look and fix it asp. Let's see can I find time later today.

@HelioGuilherme66

HelioGuilherme66 commented Oct 14, 2016 •

Copy link
Copy Markdown
Member

@aaltat I have already fixed Travis build. I have restarted the build of this PR.

@aaltat

aaltat commented Oct 14, 2016

Copy link
Copy Markdown
Contributor

The pull request needs to rebased locally with master and push again to upstream.

While we are not having Selenium 3.0 working, with external `geckodriver`, we use lower versions of stable Firefox.
We are not ready for Selenium 3.0 yet.
@aaltat
aaltat merged commit bf2404a into robotframework:master Oct 14, 2016
HelioGuilherme66 pushed a commit to HelioGuilherme66/robotframework-seleniumlibrary that referenced this pull request Oct 15, 2016
…ramework#674)

* Added method to find element by class name robotframework#673

* Changes to use Firefox ESR (45.4.0)

While we are not having Selenium 3.0 working, with external `geckodriver`, we use lower versions of stable Firefox.

* Changes to use Selenium 2.53.6 (and not 3.0)

We are not ready for Selenium 3.0 yet.
VitoAlbano pushed a commit to VitoAlbano/Selenium2Library that referenced this pull request Oct 18, 2016
…ramework#674)

* Added method to find element by class name robotframework#673

* Changes to use Firefox ESR (45.4.0)

While we are not having Selenium 3.0 working, with external `geckodriver`, we use lower versions of stable Firefox.

* Changes to use Selenium 2.53.6 (and not 3.0)

We are not ready for Selenium 3.0 yet.
@Gaurang033
Gaurang033 deleted the branch1 branch January 11, 2017 14:28
HelioGuilherme66 added a commit to HelioGuilherme66/robotframework-seleniumlibrary that referenced this pull request Jan 29, 2017
There are entries obsolete or overridden by others.
The goal is to keep Selenium2Library compatible with Python 2.7 and 3.x.

There is still discussion on the best way to solve compatability problems,
like for example, 'unicode'. See https://github.com/robotframework/Selenium2Library/pull/720 for more info on this.

Commits entries:
Changes to Travis settings to allow installation dependent on Python versions.
Transformed print statement into function. Compatible with Python 2.6.
Fixes import to be compatible with RobotFramework 3.0.
Changes Travis settings to install RobotFramework 3.0.
Separates imports per line, for better code readability.
Adds 'future' dependency and information to install it.
Upgrades Travis firefox to latest-esr.
Fixes ez_setup.py. Changes version to 1.8.0b2.
Removes selenium version dependency, current version is 2.53.2.
Add GitHub process files.
Update CONTRIBUTING.md
Fixed Issues URL to point to my fork.
Update ISSUE_TEMPLATE.md
Fix typo
Libdoc updates - link to project and fix 404 (robotframework#668)
* Fix 404 due to RF migration to Github
* Link to project page
* Format corrections per PR comments
* fix pronoun usage
Added method to find element by class name robotframework#673 (robotframework#674)
* Added method to find element by class name robotframework#673
* Changes to use Firefox ESR (45.4.0)
While we are not having Selenium 3.0 working, with external `geckodriver`, we use lower versions of stable Firefox.
* Changes to use Selenium 2.53.6 (and not 3.0)
We are not ready for Selenium 3.0 yet.
Updated Travis config.
Fixes installer for both Python 2.7 and 3.x.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants