Repository navigation
Fix running unit tests py3 - #656
Closed
HelioGuilherme66 wants to merge 2 commits into
Closed
HelioGuilherme66 wants to merge 2 commits into
HelioGuilherme66 wants to merge 2 commits into
Conversation
Comments one unit test. Replaces unicode function by str for Python 3.
8 of 9 tasks
Contributor
|
After the unit test runner changes is this needed? |
Member
|
This PR seems to be pretty broken. Better to get imports fixed first and look at other Python 3 fixes then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR unit tests will pass in both Python 2.7 and 3.4.
Implies #653 being applied before
Removes one unit test:
Test run:
[helio@localhost robotframework-selenium2library]$ python3 test/run_unit_tests.py
...........................................................................................................
Ran 107 tests in 0.027s
OK
[helio@localhost robotframework-selenium2library]$ python2 test/run_unit_tests.py
...........................................................................................................
Ran 107 tests in 0.052s
OK