You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, I think it would be better to have one PR to fix all print statements.
Secondly, the change in this PR doesn't work correctly without from __future__ import print_function. In Python 2 using print() will print () without the aforementioned import.
Because print statement is used mainly on the development tools, that would put the future installation requirement to the requirements-dev.txt. But if need to use the future in places which are used by the library itself then the future installation requirement should go to requirements.txt. I do not see that far, that I could say for sure for which one it should be put. Because not the need is only on the dev tools, should we put the installation requirement only in the requirements-dev.txt?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.