Skip to content

Unify print() usage (#684) - #649

Closed
aaltat wants to merge 1 commit into
robotframework:masterfrom
aaltat:master
Closed

aaltat wants to merge 1 commit into
robotframework:masterfrom
aaltat:master

Conversation

@aaltat

@aaltat aaltat commented Sep 5, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@pekkaklarck

Copy link
Copy Markdown
Member

First of all, I think it would be better to have one PR to fix all print statements.

Secondly, the change in this PR doesn't work correctly without from __future__ import print_function. In Python 2 using print() will print () without the aforementioned import.

@aaltat

aaltat commented Sep 5, 2016

Copy link
Copy Markdown
Contributor Author

Ah, so true. Then I will add the import

@aaltat

aaltat commented Sep 10, 2016

Copy link
Copy Markdown
Contributor Author

Because print statement is used mainly on the development tools, that would put the future installation requirement to the requirements-dev.txt. But if need to use the future in places which are used by the library itself then the future installation requirement should go to requirements.txt. I do not see that far, that I could say for sure for which one it should be put. Because not the need is only on the dev tools, should we put the installation requirement only in the requirements-dev.txt?

@pekkaklarck

pekkaklarck commented Sep 10, 2016 •

Copy link
Copy Markdown
Member

from __future__ import print_function works out-of-the-box since Python 2.6. In fact, all __future__ imports are handled by Python itself.

@aaltat

aaltat commented Oct 28, 2016

Copy link
Copy Markdown
Contributor Author

Closed on favor of #684

@aaltat aaltat closed this Oct 28, 2016
@HelioGuilherme66 HelioGuilherme66 changed the title Unify print() usage (#648) Unify print() usage (#684) Oct 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants