Repository navigation
Makes Selenium2Library compatible with RobotFramework 3.0 and Python 3.4, 2.7 and 2.6 - #564
Closed
HelioGuilherme66 wants to merge 37 commits into
Closed
HelioGuilherme66 wants to merge 37 commits into
HelioGuilherme66 wants to merge 37 commits into
Conversation
…versions. Already has some settings for Python 3.4, but disabled.
Changes Travis settings to install RobotFramework 3.0.
under Python 2.6, 2.7 and 3.4. Activates Python 3.4 in Travis config. Changed files with futurize from http://python-future.org/: build_dist.py demo/demoapp/server.py demo/package.py doc/buildhtml.py setup.py src/Selenium2Library/__init__.py src/Selenium2Library/keywords/__init__.py src/Selenium2Library/keywords/_alert.py src/Selenium2Library/keywords/_browsermanagement.py src/Selenium2Library/keywords/_cookie.py src/Selenium2Library/keywords/_element.py src/Selenium2Library/keywords/_formelement.py src/Selenium2Library/keywords/_javascript.py src/Selenium2Library/keywords/_logging.py src/Selenium2Library/keywords/_runonfailure.py src/Selenium2Library/keywords/_screenshot.py src/Selenium2Library/keywords/_selectelement.py src/Selenium2Library/keywords/_tableelement.py src/Selenium2Library/keywords/_waiting.py src/Selenium2Library/keywords/keywordgroup.py src/Selenium2Library/locators/__init__.py src/Selenium2Library/locators/customlocator.py src/Selenium2Library/locators/elementfinder.py src/Selenium2Library/locators/tableelementfinder.py src/Selenium2Library/locators/windowmanager.py src/Selenium2Library/utils/__init__.py src/Selenium2Library/utils/events/__init__.py src/Selenium2Library/utils/events/event.py src/Selenium2Library/utils/events/scope_event.py src/Selenium2Library/utils/librarylistener.py src/Selenium2Library/webdrivermonkeypatches.py src/ez_setup.py test/lib/mockito/__init__.py test/lib/mockito/inorder.py test/lib/mockito/invocation.py test/lib/mockito/matchers.py test/lib/mockito/mock_registry.py test/lib/mockito/mocking.py test/lib/mockito/mockito.py test/lib/mockito/spying.py test/lib/mockito/verification.py test/resources/statuschecker.py test/resources/testserver/testserver.py test/run_tests.py test/unit/keywords/test_browsermanagement.py test/unit/utils/test_browsercache.py
Contributor
There was a problem hiding this comment.
Let's remove all the extraneous quotes here.
Member
Author
There was a problem hiding this comment.
I left the quotes there because I think that it is intended to print a comment.
Contributor
|
Have you looked through the 3.4 errors? There seems to be a lot of them... Lots of elements couldn't be found. |
Tested in Python 2.6, 2.7 and 3.4. (thanks to @rickypc)
Member
Author
|
In my last commit (8e95b3f) I changed the way how python is called, by using the version suffix. There are problems with Python3.4 ../http/server.py code. That is why the Travis is failing with Python3.4. You may verify that the demo starts the server correctly (and also other tests I have). |
HelioGuilherme66
changed the title
Member
|
I'm sorry but this PR is so big and touches so many places that I don't have time to review and comment it in detail. Some general comments:
|
Add GitHub process files.
Fixed Issues URL to point to my fork.
Fix typo
Version >=2.53.0 is breaking Unselect From List By Value.
Fixes `Unselect From List` due to Selenium changes.
…ibrary into code_futurized
Testing Pull Request Template
Contributor
|
I think Pekka comment is still a valid one. And also the commit history is awful. |
Member
Author
Update CONTRIBUTING.md Fixes test run in Fedora.
modified: CONTRIBUTING.md modified: src/Selenium2Library/keywords/_browsermanagement.py
Merged
* Fix 404 due to RF migration to Github * Link to project page * Format corrections per PR comments * fix pronoun usage
While we are not having Selenium 3.0 working, with external `geckodriver`, we use lower versions of stable Firefox.
We are not ready for Selenium 3.0 yet.
…ramework#674) * Added method to find element by class name robotframework#673 * Changes to use Firefox ESR (45.4.0) While we are not having Selenium 3.0 working, with external `geckodriver`, we use lower versions of stable Firefox. * Changes to use Selenium 2.53.6 (and not 3.0) We are not ready for Selenium 3.0 yet.
…ilure in Fedora Core 22). Get path to python/jython to run unit tests.
HelioGuilherme66
force-pushed
the
code_futurized
branch
2 times, most recently
from
November 27, 2016 01:37
b70789c to
1705d44
Compare
Sets this version to 1.8.1b1.
HelioGuilherme66
force-pushed
the
code_futurized
branch
from
November 27, 2016 01:43
1705d44 to
a834dfa
Compare
…elenium2library into code_futurized
Member
|
Most of the changes done here is already done by other PRs. This was too big PR with too many changes. to begin with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces #556 and contains PRs #559, #561, #562 and #563. Please merge them in order and look at commits to see changes grouped by code modification (not always ;).