Repository navigation
Adds ignoring "--dryrun" to rebot to allow getting the report and log. - #535
HelioGuilherme66 wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
First of all, list.remove raises ValueError, not TypeError, if the removed item doesn't exist. Secondly, it would be shorted and cleaner to use:
if '--dryrun' in args:
args.remote('--dryrun')
|
Please consider this small change of code in S2L acceptance test cases. I would like to run the tests with |
|
Is this related to the #536 ? |
|
Yes it is. I did not remember to have the issue. But the conversation drifted into RF. This is a change only to S2L. (of course I can have this only in my fork, but it would be harmless if on master) |
|
Should we open the original issue or a new one and could you explain why this is needed. And what is the problem you are trying to solve? |
Changes a flag to True to allow running unit tests in Fedora 22.
|
Can we close this issue? |
Changed documentation for set_window_position and get_window_position.
cdae034 to
902b192
Compare
|
Merged with master and is ready to be merged. |
|
You should not merge changes from master to your PRs unless changes actually affect your code. Merging creates totally unnecessary commit history. |
|
This would fit into the scope of PR #710, but I fail to see the benefits of the change. There are lot of tests that contain log level validations done by StatusChecker. All those would fail in the dry-run mode. Could you @HelioGuilherme66 clarify your use cases for |
|
I wanted to have --dryrun working to confirm that new acceptance tests were OK. I also would like to have the Report and Log generated for other experiments. |
Changes a flag to True to allow running unit tests in Fedora 22.