Fix 1301 - mention webdrivermanager in the seleniumlibrary docs.#1320
Merged
aaltat merged 2 commits intorobotframework:masterfrom Mar 11, 2019
rasjani:fix-1301
Merged
Fix 1301 - mention webdrivermanager in the seleniumlibrary docs.#1320aaltat merged 2 commits intorobotframework:masterfrom rasjani:fix-1301
aaltat merged 2 commits intorobotframework:masterfrom
rasjani:fix-1301
Conversation
Contributor
|
Looking pretty good from a mobile screen. Need to read from bigger screen too. |
aaltat
reviewed
Mar 8, 2019
Contributor
aaltat
left a comment
aaltat
left a comment
There was a problem hiding this comment.
I am happy with the README updates.
But I am not sure do I want to talk in keyword doc about the WebDrivers and least that much. Would it better to keep the first chapter and link to the README?
Contributor
|
Thank you for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just skip the update to keyword docs if its not appropriate.