Fix #88#92
Merged
Merged
Conversation
Member
There was a problem hiding this comment.
Shouldn't this be set_is_malloc_allowed (false);?
Contributor
Author
There was a problem hiding this comment.
Indeed,
Apparently I failed the merge somewhere.
I correct this
fdarricau
force-pushed
the
allocation_check
branch
from
aee979d to
44236c0
Compare
Contributor
Author
|
Done. If everything looks good to you, the branch is ready to be rebased |
Member
|
I've been thinking about the organization of the code for this. This is not a detail that should be hidden in |
fdarricau
force-pushed
the
allocation_check
branch
2 times, most recently
from
21bfa11 to
98808c6
Compare
fdarricau
force-pushed
the
allocation_check
branch
from
98808c6 to
2fb4961
Compare
fdarricau
force-pushed
the
allocation_check
branch
from
2fb4961 to
8240ecb
Compare
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMHO, the wrapping function set_is_malloc_allowed is probably not optimally placed in the code as it is not supposed to be part of the detail namespace. It is totally possible to move it to a whole new file, or even to core.hh/function.hh (even thought that does not really sounds good to me).
The other commits are basically about removing no more needed calls to set_is_malloc_allowed, thanks to the use of Eigen::Ref and making sure each call setting the varaible to true is followed by one setting it to false as soon as the allocation part is done.