fix(smolvlm): preserve processor-owned dimensions for no-resize packages - #2984
fix(smolvlm): preserve processor-owned dimensions for no-resize packages#2984imbgar-roboflow wants to merge 2 commits into
Conversation
|
👋 Thanks for the pull request! Here is how automated Claude review works here, so you spend credits (and reviewer time) wisely. 🚧 Right now this is a draft, so automated Claude review is paused — nothing is being spent yet. Mark it Ready for review to trigger it. Warning 💸 The Claude reviewer bills in credits, not vibesAutomated review spins up a real agent that reads real code and spends real credits on every pass. It is glad to help — but it is not a rubber duck, a linter you poke in a loop, or a substitute for reading the contributing guide. Treat it like an expensive senior reviewer whose time you booked, and show up prepared. Draft when unsure, Ready when you mean it:
However you get there, arrive prepared:
Reviews are not free. A draft costs nothing to review; a Ready PR is a promise that it is worth reviewing.
|
Problem
A real native SmolVLM training run completed and registered its model, but prediction failed with HTTP 500. The writer correctly recorded
network_input.training_input_size: nullbecause the dataset had no platform resize. The activeinference-modelsreader rejected that value as an invalidTrainingInputSizebefore loading the model.Change
Add a Smol-specific parser for the explicit processor-owned input contract. It accepts a null training size only with dynamic any-size RGB input and an identity platform transform, then uses the existing raw-image path into the packaged Hugging Face processor. It does not invent a resolution, alter trained artifacts, disable quantization, switch reader backends, or relax the shared fixed-size schema. Existing fixed-size packages retain their parser and preprocessing behavior. Nonidentity transforms with no size remain rejected rather than silently discarded.
Verification
sha256:8ed0a5f2c597c69979910aff7a6242a8ceeb7be7d64acd24a33828317727c4fffailed containerd extraction because its replacement layer omitted explicit directories. That failure is preserved. Corrected candidatesha256:3fb47f5a20b59eb22dc613034e750ab665052274ac707645013914c3c062c836passed actual Pod source/dependency/readiness checks.Scope
Five-file, main-based source PR: reader helper, reader integration, regression tests, isolated build profile, and hash-pinned requirements. No shared inference deployment or benchmark training image is changed. These fix a writer/reader contract mismatch and an isolated CUDA13 dependency mismatch, not the NVIDIA driver hang. Native training
72e78311b43912927047is reused; no retraining is needed to exercise these reader changes.