perf: Run sync ops in threadpool #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng (feast-dev#4610) Bumps org.apache.avro:avro from 1.11.3 to 1.11.4. --- updated-dependencies: - dependency-name: org.apache.avro:avro dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
robhowley
commented
Oct 16, 2024
| dependencies=[Depends(inject_user_details)], | ||
| ) | ||
| def get_online_features(body=Depends(get_body)): | ||
| async def get_online_features(body=Depends(get_body)): |
Owner
Author
There was a problem hiding this comment.
make endpoint async ...
robhowley
commented
Oct 16, 2024
Comment on lines
+155
to
+160
| if store._get_provider().async_supported.online.read: | ||
| response = await store.get_online_features_async(**read_params) | ||
| else: | ||
| response = await run_in_threadpool( | ||
| lambda: store.get_online_features(**read_params) | ||
| ) |
Owner
Author
There was a problem hiding this comment.
use the fastapi recommended run_in_threadpool to handle the sync case.
robhowley
changed the title
robhowley
force-pushed
the
master
branch
2 times, most recently
from
df8ba6e to
6ca3b47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see this git issue in feast
What this PR does / why we need it:
Which issue(s) this PR fixes:
Misc