Skip to content

fix: add missing explicit lifetime in ExcelSubrange return type for rust 1.83 build - #353

Merged
houqp merged 1 commit into
roapi:mainfrom
chenrui333:rust-1.83
Dec 2, 2024
Merged

houqp merged 1 commit into
roapi:mainfrom
chenrui333:rust-1.83

Conversation

@chenrui333

Copy link
Copy Markdown
Contributor

seeing some regression build failure when building roapi 0.12.0 against rust 1.83.0

  error: elided lifetime has a name
    --> columnq/src/table/excel.rs:48:10
     |
  41 | impl<'a> ExcelSubrange<'a> {
     |      -- lifetime `'a` declared here
  ...
  48 |     ) -> ExcelSubrange {
     |          ^^^^^^^^^^^^^ this elided lifetime gets resolved as `'a`
     |
  note: the lint level is defined here
    --> columnq/src/lib.rs:1:9
     |
  1  | #![deny(warnings)]
     |         ^^^^^^^^
     = note: `#[deny(elided_named_lifetimes)]` implied by `#[deny(warnings)]`

relates to Homebrew/homebrew-core#199379

… rust 1.83 build

Signed-off-by: Rui Chen <rui@chenrui.dev>
@houqp
houqp enabled auto-merge (squash) December 2, 2024 08:39
@houqp
houqp merged commit 85c55c9 into roapi:main Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants