Support for Dynamic Table Deletion #340#343
Merged
houqp merged 3 commits intoroapi:mainfrom Aug 25, 2024
Merged
Conversation
houqp
approved these changes
Aug 25, 2024
Member
|
Thanks for the PR, the change looks great to me 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#340
I did my best to mirror the
register_tableendpoint.Note that for the test to work I had to set
disable_read_only=truein thetest_api_app helperfunction.I'm fairly new to Rust so any feedback is appreciated.