Conversation
|
@jychen7 let me know if you need any help getting this over the finish line! |
|
@houqp yes, I was stuck at the above three errors and I am sorry that forgot to follow up. Could you help? |
…w::datatypes::DataType
…ion::dataframe::DataFrame, which does not implement the Copy trait
There was a problem hiding this comment.
This is the last error to fix. I don't quite understand the error and need help on this, @houqp
error: implementation of `graphql_parser::common::Text` is not general enough
--> roapi/src/context.rs:124:68
|
124 | ) -> Result<Vec<arrow::record_batch::RecordBatch>, QueryError> {
| ____________________________________________________________________^
125 | | self.cq.query_graphql(query).await
126 | | }
| |_____^ implementation of `graphql_parser::common::Text` is not general enough
|
= note: `graphql_parser::common::Text<'1>` would have to be implemented for the type `&'0 str`, for any two lifetimes `'0` and `'1`...
= note: ...but `graphql_parser::common::Text<'2>` is actually implemented for the type `&'2 str`, for some specific lifetime `'2`
There was a problem hiding this comment.
not obvious to me why this is happening yet, will have to take a closer look 🤔
There was a problem hiding this comment.
Thanks, I also take a look and have no idea...
There was a problem hiding this comment.
This is the last error to fix. I don't quite understand the error and need help on this, @houqp
error: implementation of `graphql_parser::common::Text` is not general enough --> roapi/src/context.rs:124:68 | 124 | ) -> Result<Vec<arrow::record_batch::RecordBatch>, QueryError> { | ____________________________________________________________________^ 125 | | self.cq.query_graphql(query).await 126 | | } | |_____^ implementation of `graphql_parser::common::Text` is not general enough | = note: `graphql_parser::common::Text<'1>` would have to be implemented for the type `&'0 str`, for any two lifetimes `'0` and `'1`... = note: ...but `graphql_parser::common::Text<'2>` is actually implemented for the type `&'2 str`, for some specific lifetime `'2`
I solved this by removing explicit lifetimes and changing the &str to String. Not sure if this is the recommended way, the rust experts can guide me here.
@jychen7 @houqp @rtyler I have a local branch where I have successfully upgraded roapi to the latest versions of datafusion, arrow and delta-rs, along with some other minor upgrades were required.
shall I raise a PR for it?
There was a problem hiding this comment.
Sorry @jychen7 that I dropped the ball on this one ;(
@chitralverma please feel free to send a new MR
There was a problem hiding this comment.
I am sorry that I don't have time to look into this recently, but I could try best to help review
feel free to raise a PR. I will close this one after that
|
Unfortunately Datafusion is already up to v22 🤕 There were a lot of API changes between v19 and v22 that we had to address in delta-rs, kind of a pain 😦 |
|
datafusion upgraded with #279 |
close #263
2023-03-02
issues to fix:
From<Infallible>is not implemented forColumnQErrorFrom<&SchemaTypeStruct>is not implemented fordatafusion::arrow::datatypes::Schemadatafusion::datasource::TableProvideris not implemented fordeltalake::DeltaTabledf.collect()now returns "error[E0507]: cannot move out of anArc"datafusion::dataframe::DataFrame, which does not implement theCopytraitDeserialize<'_>is not implemented fordatafusion::arrow::datatypes::DataType2023-03-25
Arc, found structDataFramegraphql_parser::common::Textis not general enougharrow_array::record_batch::RecordBatch, found structcolumnq::arrow::record_batch::RecordBatchFrom<DFSchema>is not implemented forarrow_schema::schema::SchemaDataFrame, which does not implement theCopytrait