Skip to content

chore(columnq): readability fixups in json #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
houqp merged 1 commit into from
Jan 29, 2023
Merged

chore(columnq): readability fixups in json #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions columnq/src/table/json.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ fn json_vec_to_partition(
);
let mut batches = vec![];
{
// enclose values_iter in its own scope so it won't brrow schema_ref til end of this
// enclose values_iter in its own scope so it won't borrow schema_ref til end of this
// function
let mut values_iter: Box<dyn Iterator<Item = arrow::error::Result<Value>>> =
if array_encoded {
Expand Down Expand Up @@ -132,12 +132,12 @@ async fn to_partitions(
match &pointer {
Some(p) => {
return Err(ColumnQError::LoadJson(format!(
"{p} points to an emtpy array"
"{p} points to an empty array"
)));
}
None => {
return Err(ColumnQError::LoadJson(
"JSON data is an emtpy array".to_string(),
"JSON data is an empty array".to_string(),
));
}
}
Expand Down