Merged
Conversation
This was referenced Jan 20, 2023
Merged
jychen7
commented
Jan 21, 2023
houqp
approved these changes
Jan 22, 2023
Collaborator
Author
|
I was thinking to release nvm, let's go directly to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
part of #240
Before this PR, we allow use GCS via S3 API, but it requires setup of HMAC keys and it is not native.
https://cloud.google.com/storage/docs/authentication/hmackeys
This PR adds native GCS support using Google service account. GCP workload identity is NOT supported yet, depends on apache/arrow-rs-object-store#200.
Test
Integration test is added in CI.
(I also test locally with real GCS bucket)
Document
roapi/docs#16
To Reviewer
This PR is based on #247, so need rebase if #247 is squash merge.